Hi,
The function DSChiefApprovals.etch emits an event Etch, which is not documented in the README doc.
A potential fix could be adding the description "Emits an Etch event" to the README doc.
Furthermore, function DSChiefApprovals.vote calls the etch function. So it emits the Etch event as well.
|
bytes32 slate = etch(yays); |
A potential fix could also be adding the description "Emits an Etch event" to this function in the README doc.
Could you please check it?
Thanks.
Hi,
The function
DSChiefApprovals.etchemits an eventEtch, which is not documented in the README doc.ds-chief/src/chief.sol
Line 79 in 4a833cd
A potential fix could be adding the description "Emits an
Etchevent" to the README doc.Furthermore, function
DSChiefApprovals.votecalls theetchfunction. So it emits theEtchevent as well.ds-chief/src/chief.sol
Line 86 in 4a833cd
A potential fix could also be adding the description "Emits an
Etchevent" to this function in the README doc.Could you please check it?
Thanks.