rename_images not resettable

[deekayhd]

In the LUA script "rename_images", clicking on the reset button has no effect.
@wpferguson
I am wondering if this is on purpose. The module is set as resettable in the call to darktable.register_lib and there is a method reset_callback(), but currently it does not work (entry field is not cleared). When I enable the reset, I noticed that the input field is also cleared every time darktable is started, whereas in the current version, the input field content is kept. This may be helpful, if one uses a more complex rule and does not want to re-enter it every time, especially as presets are not supported for Lua modules, right?
It is no big deal to clear the field otherwise, but also a quick fix, if desired.

[wpferguson]

I am wondering if this is on purpose

It was all part of my nefarious plan to frustrate users by giving them controls that do nothing 😈

or

I forgot to implement that part 🤦 IIRC my original thought was to clear the module if you had made a mistake or you were doing multiple renames. As far as reset on start, I'm not sure. I could be happy with loading the last used pattern, and letting the user reset if they didn't want it. It could simply be stored as a preference, then read on start and restored.

If you want to fix it, go for it. If not, I'll add it to my list 😄

[deekayhd]

It was all part of my nefarious plan to frustrate users

Well, only partly successful. I didn't get frustrated but curious. ;-)

I would like to do the fix, so your list can be concentrated on more important tasks. As you suggested, I would store the last used pattern as a hidden preference and load it on start of the script. I do not think that it is useful to offer this on the lua tab of the global preferences, though, as it may still be changed rather often.

[deekayhd]

Actually, the part with the preference was already there, so no reset when starting DT. Don't know what I saw in my earlier test, sorry.