Skip to content

[Code scan] Atomic virial outputs squeeze the wrong dimension #139

Description

@njzjz

This issue was found by a Codex global scan of the repository at commit 19f9265.

energy_derv_c is produced with shape (nf, nall, 1, 9), but the public atom_virial / extended_virial paths call .squeeze(-3). For nloc > 1, -3 is the atom axis, so the singleton derivative axis remains and the output stays 4D.

model_predict["atom_virial"] = model_ret_lower["energy_derv_c"][
:,
:nloc,
].squeeze(-3)

model_predict["extended_force"] = model_ret["energy_derv_r"].squeeze(-2)
model_predict["virial"] = model_ret["energy_derv_c_redu"].squeeze(-2)
if do_atomic_virial:
model_predict["extended_virial"] = model_ret["energy_derv_c"].squeeze(-3)

model_predict["atom_virial"] = model_ret_lower["energy_derv_c"][
:,
:nloc,
].squeeze(-3)

model_predict["extended_force"] = model_ret["energy_derv_r"].squeeze(-2)
model_predict["virial"] = model_ret["energy_derv_c_redu"].squeeze(-2)
if do_atomic_virial:
model_predict["extended_virial"] = model_ret["energy_derv_c"].squeeze(-3)

The translated output metadata has the same squeeze target:

deepmd-gnn/deepmd_gnn/mace.py

Lines 1791 to 1796 in 19f9265

output_def["force"] = deepcopy(out_def_data["energy_derv_r"])
output_def["force"].squeeze(-2)
output_def["virial"] = deepcopy(out_def_data["energy_derv_c_redu"])
output_def["virial"].squeeze(-2)
output_def["atom_virial"] = deepcopy(out_def_data["energy_derv_c"])
output_def["atom_virial"].squeeze(-3)

output_def["force"] = deepcopy(out_def_data["energy_derv_r"])
output_def["force"].squeeze(-2)
output_def["virial"] = deepcopy(out_def_data["energy_derv_c_redu"])
output_def["virial"].squeeze(-2)
output_def["atom_virial"] = deepcopy(out_def_data["energy_derv_c"])
output_def["atom_virial"].squeeze(-3)

I verified the metadata path currently reports atom_virial as [1, 9], and the runtime tensor path can return (nf, nloc, 1, 9) instead of (nf, nloc, 9).

Suggested fix: change these squeezes to .squeeze(-2) and add shape assertions for MACE and NequIP when do_atomic_virial=True.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions