Skip to content

Commit 45a4880

Browse files
committed
Enhance corpus test report
Show larger than base for all python versions Show time delta for slowest entries.
1 parent 826e813 commit 45a4880

1 file changed

Lines changed: 24 additions & 12 deletions

File tree

‎corpus_test/generate_report.py‎

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,8 @@ def report_larger_than_base(results_dir: str, python_versions: list[str], minifi
277277
yield '''
278278
## Top 10 Larger than base
279279
280-
| Corpus Entry | Original Size | Minified Size |
281-
|--------------|--------------:|--------------:|'''
280+
| Corpus Entry | Python Version | Original Size | Minified Size |
281+
|--------------|----------------|--------------:|--------------:|'''
282282

283283
there_are_some_larger_than_base = False
284284

@@ -293,17 +293,17 @@ def report_larger_than_base(results_dir: str, python_versions: list[str], minifi
293293
except FileNotFoundError:
294294
continue
295295

296-
larger_than_original = sorted(summary.compare_size_increase(base_summary), key=lambda result: result.original_size)[:10]
296+
larger_than_base = sorted(summary.compare_size_increase(base_summary), key=lambda result: result.original_size)[:10]
297297

298-
for entry in larger_than_original:
298+
for entry in larger_than_base:
299299
there_are_some_larger_than_base = True
300-
yield f'| {entry.corpus_entry} | {entry.original_size} | {entry.minified_size} ({entry.minified_size - base_summary.entries[entry.corpus_entry].minified_size:+}) |'
300+
yield f'| {entry.corpus_entry} | {python_version} | {entry.original_size} | {entry.minified_size} ({entry.minified_size - base_summary.entries[entry.corpus_entry].minified_size:+}) |'
301301

302302
if not there_are_some_larger_than_base:
303-
yield '| None | | |'
303+
yield '| None | | | |'
304304

305305

306-
def report_slowest(results_dir: str, python_versions: list[str], minifier_sha: str) -> str:
306+
def report_slowest(results_dir: str, python_versions: list[str], minifier_sha: str, base_sha: str) -> str:
307307
yield '''
308308
## Top 10 Slowest
309309
@@ -316,8 +316,18 @@ def report_slowest(results_dir: str, python_versions: list[str], minifier_sha: s
316316
except FileNotFoundError:
317317
continue
318318

319+
try:
320+
base_summary = result_summary(results_dir, python_version, base_sha)
321+
except FileNotFoundError:
322+
base_summary = None
323+
319324
for entry in sorted(summary.entries.values(), key=lambda entry: entry.time, reverse=True)[:10]:
320-
yield f'| {entry.corpus_entry} | {entry.original_size} | {entry.minified_size} | {entry.time:.3f} |'
325+
time_detail = f'{entry.time:.3f}'
326+
327+
if base_summary is not None and entry.corpus_entry in base_summary.entries:
328+
time_detail += f' ({entry.time - base_summary.entries[entry.corpus_entry].time:+.3f})'
329+
330+
yield f'| {entry.corpus_entry} | {entry.original_size} | {entry.minified_size} | {time_detail} |'
321331

322332
def format_size_change_detail(summary, base_summary) -> str:
323333
mean_percent_of_original_change = summary.mean_percent_of_original - base_summary.mean_percent_of_original
@@ -400,11 +410,13 @@ def report(results_dir: str, minifier_ref: str, minifier_sha: str, base_ref: str
400410
f'| {format_difference(summary.exception(), base_summary.exception())} |'
401411
)
402412

413+
all_versions = ['2.7', '3.3', '3.4', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
414+
403415
yield from report_larger_than_original(results_dir, ['3.14'], minifier_sha)
404-
yield from report_larger_than_base(results_dir, ['3.13'], minifier_sha, base_sha)
405-
yield from report_slowest(results_dir, ['3.14'], minifier_sha)
406-
yield from report_unstable(results_dir, ['2.7', '3.3', '3.4', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14'], minifier_sha)
407-
yield from report_exceptions(results_dir, ['2.7', '3.3', '3.4', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14'], minifier_sha)
416+
yield from report_larger_than_base(results_dir, all_versions, minifier_sha, base_sha)
417+
yield from report_slowest(results_dir, ['3.14'], minifier_sha, base_sha)
418+
yield from report_unstable(results_dir, all_versions, minifier_sha)
419+
yield from report_exceptions(results_dir, all_versions, minifier_sha)
408420

409421

410422
def main():

0 commit comments

Comments
 (0)