Skip to content

Commit 96e5f21

Browse files
authored
fix: avoid setting global root logger (#182)
Signed-off-by: Michele Dolfi <[email protected]>
1 parent 3d9deb2 commit 96e5f21

File tree

4 files changed

+17
-22
lines changed

4 files changed

+17
-22
lines changed

docling_parse/pdf_parser.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@
2727
from docling_parse.pdf_parsers import pdf_sanitizer # type: ignore[import]
2828

2929
# Configure logging
30-
logging.basicConfig(
31-
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
32-
)
30+
_log = logging.getLogger(__name__)
3331

3432

3533
class PdfDocument:
@@ -442,25 +440,25 @@ def _to_segmented_page(
442440
segmented_page.word_cells = self._to_cells(page["word_cells"])
443441
segmented_page.has_words = len(segmented_page.word_cells) > 0
444442
elif keep_chars:
445-
logging.warning(
443+
_log.warning(
446444
"`words` will be created for segmented_page in an inefficient way!"
447445
)
448446
self._create_word_cells(segmented_page, enforce_same_font=enforce_same_font)
449447
# else:
450-
# logging.warning("No `words` will be created for segmented_page")
448+
# _log.warning("No `words` will be created for segmented_page")
451449

452450
if create_textlines and ("line_cells" in page):
453451
segmented_page.textline_cells = self._to_cells(page["line_cells"])
454452
segmented_page.has_lines = len(segmented_page.textline_cells) > 0
455453
elif keep_chars:
456-
logging.warning(
454+
_log.warning(
457455
"`text_lines` will be created for segmented_page in an inefficient way!"
458456
)
459457
self._create_textline_cells(
460458
segmented_page, enforce_same_font=enforce_same_font
461459
)
462460
# else:
463-
# logging.warning("No `text_lines` will be created for segmented_page")
461+
# _log.warning("No `text_lines` will be created for segmented_page")
464462

465463
return segmented_page
466464

docling_parse/processing_dir.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@
1111

1212
from docling_parse import pdf_parser_v2 # type: ignore[attr-defined]
1313

14-
# Configure logging
15-
logging.basicConfig(
16-
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
17-
)
18-
1914

2015
@dataclass
2116
class FileTask:
@@ -153,6 +148,10 @@ def process_files_from_queue(file_queue: Queue, page_level: bool, loglevel: str)
153148

154149

155150
def main():
151+
# Configure logging
152+
logging.basicConfig(
153+
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
154+
)
156155

157156
directory, recursive, loglevel, page_level_parsing = parse_arguments()
158157

docling_parse/processing_s3.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@
2727

2828
from docling_parse import pdf_parser_v2 # type: ignore[attr-defined]
2929

30-
# Configure logging
31-
logging.basicConfig(
32-
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
33-
)
34-
3530
queue_lock = threading.Lock()
3631

3732

@@ -342,6 +337,10 @@ def process_files_from_queue(
342337

343338

344339
def main():
340+
# Configure logging
341+
logging.basicConfig(
342+
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
343+
)
345344

346345
s3_config, threads, loglevel = parse_arguments()
347346

docling_parse/visualize.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@
88

99
from docling_parse.pdf_parser import DoclingPdfParser, PdfDocument
1010

11-
# Configure logging
12-
logging.basicConfig(
13-
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
14-
)
15-
1611

1712
def parse_args():
1813
parser = argparse.ArgumentParser(description="Process a PDF file.")
@@ -254,6 +249,10 @@ def visualise_py(
254249

255250

256251
def main():
252+
# Configure logging
253+
logging.basicConfig(
254+
level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s"
255+
)
257256

258257
(
259258
log_level,

0 commit comments

Comments
 (0)