Skip to content

Improve diagnostic logging for exceptions throw in InvokableObjectManager #9817

@ReubenBond

Description

@ReubenBond

When logging these exceptions, we should also log details about the local object, eg the object class type and GrainId:

System.NullReferenceException: Object reference not set to an instance of an object.
   at OrleansCodeGen.Orleans.Runtime.Invokable_IGrainCallCancellationExtension_GrainReference_Ext_FA239824.InvokeInner() in /_/src/Orleans.Core/obj/Release/net8.0/Orleans.CodeGenerator/Orleans.CodeGenerator.OrleansSerializationSourceGenerator/Orleans.Core.orleans.g.cs:line 69
   at Orleans.Runtime.Request.Invoke() in /_/src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:line 615
--- End of stack trace from previous location ---
   at Orleans.Runtime.GrainMethodInvoker.Invoke() in /_/src/Orleans.Core/Core/GrainMethodInvoker.cs:line 132
   at XXX.Services.Orleans.RetryFilter.Invoke(IIncomingGrainCallContext context) in /mnt/vss/_work/1/s/src/libraries/XXX.Services.Orleans/Filters/RetryFilter.cs:line 98
   at Orleans.Runtime.GrainMethodInvoker.Invoke() in /_/src/Orleans.Core/Core/GrainMethodInvoker.cs:line 94
   at XXX.Services.Orleans.IncomingTelemetryFilter.Invoke(IIncomingGrainCallContext context) in /mnt/vss/_work/1/s/src/libraries/XXX.Services.Orleans/Filters/IncomingTelemetryFilter.cs:line 75
   at Orleans.Runtime.GrainMethodInvoker.Invoke() in /_/src/Orleans.Core/Core/GrainMethodInvoker.cs:line 94
   at Orleans.InvokableObjectManager.LocalObjectData.LocalObjectMessagePumpAsync() in /_/src/Orleans.Core/Runtime/InvokableObjectManager.cs:line 246

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions