Skip to content

Creating Partner breaking with Country struct #133

@wynandmeintjes

Description

@wynandmeintjes

In version github.com/dubinc/dub-go v0.17.1 the partner was created with a country struct

	// The partner's country of residence. Must be passed as a 2-letter ISO 3166-1 country code. Learn more: https://d.to/geo
	Country *Country `json:"country,omitempty"`

whereas with github.com/dubinc/dub-go v0.18.0 the partner now gets created with a country *string

	// The partner's country of residence. Must be passed as a 2-letter ISO 3166-1 country code. See https://d.to/geo for more information.
	Country *string `json:"country,omitempty"`

This is definitely a nice improvement since I no longer need to map country codes to your country structs. That said, it feels like it should have been released as a breaking change, or at the very least mentioned in the release notes as part of the migration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions