11from __future__ import annotations
22
33import asyncio
4+ import gc
45import hashlib
56import json
7+ import weakref
68from typing import Any
79
810import httpx
@@ -310,12 +312,20 @@ def runtime_envelope(server: FakeRuntimePayloadServer, value: Any) -> dict[str,
310312 return {"codec" : "avro" , "external_payload" : server .seed (blob )}
311313
312314
315+ def payload_worker (client : Client , * , capabilities : list [str ] | None = None ) -> Worker :
316+ worker = Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [RuntimePayloadReplayWorkflow ],
317+ capabilities = capabilities or [])
318+ worker ._begin_run ()
319+ worker ._registration_done .set ()
320+ return worker
321+
322+
313323@pytest .mark .asyncio
314324@pytest .mark .parametrize ("history_page" , [False , True ])
315325async def test_worker_confirms_original_lease_before_and_after_payload_hydration (history_page : bool ) -> None :
316326 server = FakeRuntimePayloadServer ()
317327 client = runtime_client (server )
318- Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [ RuntimePayloadReplayWorkflow ] )
328+ payload_worker (client )
319329 task = {"task_id" : "task-1" , "lease_owner" : "worker-1" , "workflow_task_attempt" : 3 ,
320330 "arguments" : runtime_envelope (server , ["original-input" ])}
321331 path = "/api/worker/workflow-tasks/task-1/history" if history_page else "/api/worker/workflow-tasks/poll"
@@ -356,7 +366,7 @@ async def test_worker_does_not_fetch_payload_when_original_claim_is_not_confirme
356366) -> None :
357367 server = FakeRuntimePayloadServer ()
358368 client = runtime_client (server )
359- Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [ RuntimePayloadReplayWorkflow ] )
369+ payload_worker (client )
360370 server .responses [("POST" , "/api/worker/workflow-tasks/poll" )] = {"task" : {
361371 "task_id" : "task-1" , "lease_owner" : "worker-1" , "workflow_task_attempt" : 3 ,
362372 "arguments" : runtime_envelope (server , ["never-executed" ]),
@@ -378,8 +388,7 @@ async def test_payload_renewal_preserves_new_cancellation_for_canonical_delivery
378388
379389 server = FakeRuntimePayloadServer ()
380390 client = runtime_client (server )
381- worker = Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [RuntimePayloadReplayWorkflow ],
382- capabilities = ["cooperative_cancellation" ])
391+ worker = payload_worker (client , capabilities = ["cooperative_cancellation" ])
383392 worker ._cooperative_cancellation_supported = True
384393 original = observation ()
385394 server .responses [("POST" , "/api/worker/workflow-tasks/poll" )] = {"task" : {
@@ -403,7 +412,7 @@ async def test_payload_renewal_preserves_new_cancellation_for_canonical_delivery
403412async def test_stopped_worker_does_not_start_claim_payload_download () -> None :
404413 server = FakeRuntimePayloadServer ()
405414 client = runtime_client (server )
406- worker = Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [ RuntimePayloadReplayWorkflow ] )
415+ worker = payload_worker (client )
407416 worker ._stop .set ()
408417 server .responses [("POST" , "/api/worker/workflow-tasks/poll" )] = {"task" : {
409418 "task_id" : "task-1" , "lease_owner" : "worker-1" , "workflow_task_attempt" : 3 ,
@@ -424,7 +433,9 @@ async def test_payload_transfer_is_cancelled_when_its_periodic_lease_observer_lo
424433) -> None :
425434 server = FakeRuntimePayloadServer ()
426435 client = runtime_client (server )
427- Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [RuntimePayloadReplayWorkflow ])
436+ payload_worker (client )
437+
438+
428439 server .responses [("POST" , "/api/worker/workflow-tasks/poll" )] = {"task" : {
429440 "task_id" : "task-1" , "lease_owner" : "worker-1" , "workflow_task_attempt" : 3 ,
430441 "arguments" : runtime_envelope (server , ["never-executed" ]),
@@ -470,6 +481,36 @@ async def prompt_observation(delay: float) -> None:
470481 await client .aclose ()
471482
472483
484+ @pytest .mark .asyncio
485+ async def test_shared_client_does_not_retain_unstarted_or_stopped_workers () -> None :
486+ client = runtime_client (FakeRuntimePayloadServer ())
487+ worker = Worker (client , task_queue = "billing" , worker_id = "worker-1" , workflows = [RuntimePayloadReplayWorkflow ])
488+ assert client ._workflow_payload_observers == {}
489+ reference = weakref .ref (worker )
490+ worker ._begin_run ()
491+ worker ._registration_done .set ()
492+ assert "worker-1" in client ._workflow_payload_observers
493+ await worker .stop ()
494+ assert client ._workflow_payload_observers == {}
495+ del worker
496+ await asyncio .sleep (0 )
497+ gc .collect ()
498+ assert reference () is None
499+ await client .aclose ()
500+
501+
502+ @pytest .mark .asyncio
503+ async def test_stopping_old_worker_preserves_a_new_worker_observer () -> None :
504+ client = runtime_client (FakeRuntimePayloadServer ())
505+ older = payload_worker (client )
506+ newer = payload_worker (client )
507+ await older .stop ()
508+ assert client ._workflow_payload_observers ["worker-1" ] == newer ._renew_workflow_payload_lease
509+ await newer .stop ()
510+ assert client ._workflow_payload_observers == {}
511+ await client .aclose ()
512+
513+
473514@pytest .mark .asyncio
474515@pytest .mark .parametrize ("threshold_bytes" , [1 , 4096 ])
475516async def test_nexus_arguments_offload_without_changing_recorded_arguments (threshold_bytes : int ) -> None :
0 commit comments