use input redirection for mysql structure_load

Author: greg-rychlewski

.github/workflows/ci.yml

@@ -83,6 +83,7 @@ jobs:
         mysql:
           - "5.7"
           - "8.0"
+          - "9.4"
     steps:
       - uses: earthly/actions-setup@v1
       - uses: actions/checkout@v3

lib/ecto/adapters/myxql.ex

@@ -419,13 +419,13 @@ defmodule Ecto.Adapters.MyXQL do
     case File.read(path) do
       {:ok, contents} ->
         args = [
-          "--execute",
-          "SET FOREIGN_KEY_CHECKS = 0; " <> contents <> "; SET FOREIGN_KEY_CHECKS = 1",
+          "--init-command",
+          "SET FOREIGN_KEY_CHECKS = 0;",
           "--database",
           config[:database]
         ]
 
-        case run_with_cmd("mysql", config, args) do
+        case run_with_port("mysql", config, args, contents) do
           {_output, 0} -> {:ok, path}
           {output, _} -> {:error, output}
         end
@@ -497,6 +497,12 @@ defmodule Ecto.Adapters.MyXQL do
               "please guarantee it is available before running ecto commands"
     end
 
+    {args, cmd_opts} = args_cmd_opts(opts, opt_args, cmd_opts)
+
+    System.cmd(cmd, args, cmd_opts)
+  end
+
+  defp args_cmd_opts(opts, opt_args, cmd_opts) do
     env =
       if password = opts[:password] do
         [{"MYSQL_PWD", password}]
@@ -530,6 +536,77 @@ defmodule Ecto.Adapters.MyXQL do
       |> Keyword.put_new(:stderr_to_stdout, true)
       |> Keyword.update(:env, env, &Enum.concat(env, &1))
 
-    System.cmd(cmd, args, cmd_opts)
+    {args, cmd_opts}
+  end
+
+  // Largely ported from Elixir System.cmd implementation
+  // with the intent of using file redirection for passing
+  // dump files into the mysql client so that users don't
+  // run into shell limits when dump files are large
+  defp run_with_port(cmd, opts, opt_args, contents, cmd_opts \\ []) do
+    unless System.find_executable(cmd) do
+      raise "could not find executable `#{cmd}` in path, " <>
+              "please guarantee it is available before running ecto commands"
+    end
+
+    {args, cmd_opts} = args_cmd_opts(opts, opt_args, cmd_opts)
+
+    cmd =
+      if Path.type(cmd) == :absolute do
+        cmd
+      else
+        :os.find_executable(cmd) || :erlang.error(:enoent, [command, args, cmd_opts])
+      end
+
+    port_opts = port_opts(cmd_opts, [args: args])
+    port = Port.open({:spawn_executable, cmd}, port_opts)
+    Port.command(port, content)
+
+    try do
+      {initial, fun} = Collectable.into("")
+      do_port_byte(port, initial, fun)
+    catch
+      kind, reason ->
+        fun.(initial, :halt)
+        :erlang.raise(kind, reason, __STACKTRACE__)
+    else
+      {acc, status} -> {fun.(acc, :done), status}
+    end
+  end
+
+  defp port_opts([{:stderr_to_stdout, true} | t], acc),
+    do: port_opts(t, [:stderr_to_stdout | acc])
+
+  defp port_opts([{:stderr_to_stdout, _} | t], acc),
+    do: port_opts(t, acc)
+
+  defp port_opts([{:env, enum} | t], acc),
+    do: port_opts(t, [{:env, validate_env(enum)} | acc])
+
+  defp port_opts([], acc) do
+    [:use_stdio, :exit_status, :binary, :hide] ++ acc
+  end
+
+  defp validate_env(enum) do
+    Enum.map(enum, fn
+      {k, nil} ->
+        {String.to_charlist(k), false}
+
+      {k, v} ->
+        {String.to_charlist(k), String.to_charlist(v)}
+
+      other ->
+        raise ArgumentError, "invalid environment key-value #{inspect(other)}"
+    end)
+  end
+
+  defp do_port_byte(port, acc, fun) do
+    receive do
+      {^port, {:data, data}} ->
+        do_port_byte(port, fun.(acc, {:cont, data}), fun)
+
+      {^port, {:exit_status, status}} ->
+        {acc, status}
+    end
   end
 end