Skip to content

InMemoryStorableConversation should store from/to attribution #4

Description

@jasperblues

Problem

InMemoryStorableConversation.addMessageFromTo() silently ignores the from and to parameters, delegating directly to addMessage(). This means message attribution is lost in-memory, which could cause subtle bugs when testing multi-party chat scenarios.

Current behavior

override fun addMessageFromTo(message: Message, from: User?, to: User?): Message {
    return addMessage(message)
}

Proposed fix

Store attribution in a side map (e.g., Map<String, Pair<User?, User?>> keyed by message ID) so that in-memory conversations faithfully track from/to like StoredConversation does with Neo4j graph relationships.

This would make in-memory conversations a more accurate stand-in for stored conversations in tests.

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions