From 1eefa615b76f6b90c69e69d115e7e8ec970afae0 Mon Sep 17 00:00:00 2001 From: Gruz Date: Sat, 21 Aug 2021 22:28:06 +0300 Subject: [PATCH] Fix PHP 8 error Trying to run native sail docker I got error ``` During class fetch: Uncaught ErrorException: Required parameter $joins follows optional parameter $or in /var/www/html/vendor/optimus/bruno/src/EloquentBuilderTrait.php:106 ``` https://stackoverflow.com/a/65297280/518704 To this is a fix --- src/EloquentBuilderTrait.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/EloquentBuilderTrait.php b/src/EloquentBuilderTrait.php index 4df1d12..f0a9aa1 100644 --- a/src/EloquentBuilderTrait.php +++ b/src/EloquentBuilderTrait.php @@ -103,7 +103,7 @@ protected function applyFilterGroups(Builder $queryBuilder, array $filterGroups * @param bool|false $or * @param array $joins */ - protected function applyFilter(Builder $queryBuilder, array $filter, $or = false, array &$joins) + protected function applyFilter(Builder $queryBuilder, array $filter, $or, array &$joins) { // Destructure Shorthand Filtering Syntax if filter is Shorthand if (! array_key_exists('key', $filter) && count($filter) >= 3) {