cleanups

Author: julienrbrt

apps/testapp/kv/kvexecutor.go

@@ -249,7 +249,6 @@ func (k *KVExecutor) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight u
 
 		parts := strings.SplitN(string(tx), "=", 2)
 		if len(parts) != 2 {
-			// Log but don't fail - this is gibberish that should be filtered out
 			fmt.Printf("Warning: filtering out malformed transaction at index %d in block %d (expected format key=value): %s\n", i, blockHeight, string(tx))
 			invalidTxCount++
 			continue

execution/evm/execution.go

@@ -252,10 +252,8 @@ func (c *EngineClient) GetTxs(ctx context.Context) ([][]byte, error) {
 // ExecuteTxs executes the given transactions at the specified block height and timestamp
 func (c *EngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight uint64, timestamp time.Time, prevStateRoot []byte) (updatedStateRoot []byte, maxBytes uint64, err error) {
 	// Filter out invalid transactions to handle gibberish gracefully
-	// According to Executor interface: "Must handle gracefully gibberish transactions"
 	validTxs := make([]string, 0, len(txs))
 	for i, tx := range txs {
-		// Skip empty transactions
 		if len(tx) == 0 {
 			c.logger.Debug().
 				Int("tx_index", i).
@@ -267,7 +265,6 @@ func (c *EngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight
 		// Validate that the transaction can be parsed as an Ethereum transaction
 		var ethTx types.Transaction
 		if err := ethTx.UnmarshalBinary(tx); err != nil {
-			// Log but don't fail - this is gibberish that should be filtered out
 			c.logger.Warn().
 				Int("tx_index", i).
 				Uint64("block_height", blockHeight).
@@ -277,11 +274,9 @@ func (c *EngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight
 			continue
 		}
 
-		// Transaction is valid, add it to the payload
 		validTxs = append(validTxs, "0x"+hex.EncodeToString(tx))
 	}
 
-	// Log filtering results
 	if len(validTxs) < len(txs) {
 		c.logger.Info().
 			Int("total_txs", len(txs)).
@@ -290,7 +285,6 @@ func (c *EngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight
 			Uint64("block_height", blockHeight).
 			Msg("filtered out invalid transactions")
 	}
-
 	txsPayload := validTxs
 
 	prevBlockHash, _, prevGasLimit, _, err := c.getBlockInfo(ctx, blockHeight-1)

execution/evm/execution_status_test.go

@@ -251,69 +251,3 @@ func TestRetryWithBackoffOnPayloadStatus_WrappedRPCErrors(t *testing.T) {
 	// Should fail immediately without retries on non-syncing errors
 	assert.Equal(t, 1, attempts, "expected exactly 1 attempt, got %d", attempts)
 }
-
-// TestExecuteTxs_GibberishTransactions tests that the EVM executor handles invalid/gibberish transactions gracefully
-// According to the Executor interface requirements: "Must handle gracefully gibberish transactions"
-func TestExecuteTxs_GibberishTransactions(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		name         string
-		transactions [][]byte
-		description  string
-	}{
-		{
-			name: "completely invalid transaction data",
-			transactions: [][]byte{
-				[]byte("not a valid transaction"),
-				[]byte("gibberish"),
-				{0x00, 0x01, 0x02, 0x03},
-			},
-			description: "random bytes that don't form valid RLP-encoded transactions",
-		},
-		{
-			name:         "empty transactions",
-			transactions: [][]byte{{}, {}},
-			description:  "empty byte slices",
-		},
-		{
-			name: "mix of invalid and potentially valid looking data",
-			transactions: [][]byte{
-				[]byte("0xinvalidhex"),
-				{0xff, 0xff, 0xff, 0xff},
-				[]byte("random string"),
-			},
-			description: "various forms of invalid transaction data",
-		},
-		{
-			name:         "empty transaction list",
-			transactions: [][]byte{},
-			description:  "no transactions at all should still produce a valid block",
-		},
-	}
-
-	for _, tt := range tests {
-		tt := tt
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-
-			// Note: This test documents the expected behavior but cannot run without a real EVM client
-			// The EVM executor should:
-			// 1. Filter out invalid transactions before submitting to engine API
-			// 2. OR handle INVALID payload status gracefully
-			// 3. Still produce a valid block (possibly empty) and return a valid state root
-			// 4. NOT return an error that crashes the node
-
-			t.Logf("Testing gibberish transaction handling: %s", tt.description)
-			t.Logf("Transactions count: %d", len(tt.transactions))
-
-			// The actual implementation should ensure that when ExecuteTxs is called with
-			// gibberish transactions, it either:
-			// - Filters them out and creates an empty block
-			// - Wraps them in a way the engine accepts
-			// - Catches INVALID status and continues with a valid empty block
-			//
-			// It should NOT propagate the error up as a critical failure
-		})
-	}
-}