idomatic getter

julienrbrt · julienrbrt · commit fedcb3bc9d49 · 2025-11-21T09:24:54.000+01:00
diff --git a/block/internal/syncing/syncer.go b/block/internal/syncing/syncer.go
@@ -177,7 +177,7 @@ func (s *Syncer) SetLastState(state types.State) {
 
 // GetDAHeight returns the current DA height
 func (s *Syncer) GetDAHeight() uint64 {
-	return max(s.daHeight.Load(), s.cache.DaHeight())
+	return s.daHeight.Load()
 }
 
 // SetDAHeight updates the DA height
@@ -298,7 +298,7 @@ func (s *Syncer) fetchDAUntilCaughtUp() error {
 		default:
 		}
 
-		daHeight := s.GetDAHeight()
+		daHeight := max(s.GetDAHeight(), s.cache.DaHeight())
 
 		events, err := s.daRetriever.RetrieveFromDA(s.ctx, daHeight)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ func (s *Syncer) SetLastState(state types.State) {`
`177`	`177`
`178`	`178`	`// GetDAHeight returns the current DA height`
`179`	`179`	`func (s *Syncer) GetDAHeight() uint64 {`
`180`		`- return max(s.daHeight.Load(), s.cache.DaHeight())`
	`180`	`+ return s.daHeight.Load()`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`// SetDAHeight updates the DA height`
`@@ -298,7 +298,7 @@ func (s *Syncer) fetchDAUntilCaughtUp() error {`
`298`	`298`	`default:`
`299`	`299`	`}`
`300`	`300`
`301`		`- daHeight := s.GetDAHeight()`
	`301`	`+ daHeight := max(s.GetDAHeight(), s.cache.DaHeight())`
`302`	`302`
`303`	`303`	`events, err := s.daRetriever.RetrieveFromDA(s.ctx, daHeight)`
`304`	`304`	`if err != nil {`