Skip to content

False positives for rocket fired event log #242

@Cooldude2606

Description

@Cooldude2606

Factorio version
Version number: 1.1.87

Scenario version
Version number: 6.2.1

Bug description
There are a few cases of false positives for the rocket/nuke fired event in the decon log. The cause is because there is no "fired" event in factorio, rather we rely on on_player_ammo_inventory_changed which can be raised by equiping rockets for the first time or by switching between rockets and explosive rockets.

Reproduction method
Steps to reproduce the behavior:

  1. Have both rockets and explosive rockets in your inventory.
  2. Equip the rockets, this will emit an event in the log.
  3. Equip the explosive rockets in the same slot, this will raise another event in th log.
  4. Keep switching between the two, a new log line is added each time.

Expected behavior
Log events should only be emited when a rocket is fired.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugReporting/fixing a bug, error, or desync

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions