perf: reduce microtasks

Author: gajus

.changeset/tidy-geese-sin.md

@@ -0,0 +1,5 @@
+---
+"slonik": patch
+---
+
+reduce microtasks

packages/slonik/src/connectionMethods/query.ts

@@ -7,7 +7,6 @@ import type {
   QueryResultRow,
 } from '../types.js';
 import type { DriverNotice, DriverQueryResult } from '@slonik/driver';
-import { SlonikError } from '@slonik/errors';
 
 const executionRoutine: ExecutionRoutine = async (
   finalConnection,
@@ -42,30 +41,22 @@ const executionRoutine: ExecutionRoutine = async (
   };
 };
 
-export const query: InternalQueryMethod = async (
+export const query: InternalQueryMethod = (
   connectionLogger,
   connection,
   clientConfiguration,
   slonikSql,
   inheritedQueryId,
   integrityValidation,
 ) => {
-  try {
-    return await executeQuery(
-      connectionLogger,
-      connection,
-      clientConfiguration,
-      slonikSql,
-      inheritedQueryId,
-      executionRoutine,
-      false,
-      integrityValidation,
-    );
-  } catch (error) {
-    if (error instanceof SlonikError) {
-      connection.events.emit('error', error);
-    }
-
-    throw error;
-  }
+  return executeQuery(
+    connectionLogger,
+    connection,
+    clientConfiguration,
+    slonikSql,
+    inheritedQueryId,
+    executionRoutine,
+    false,
+    integrityValidation,
+  );
 };

packages/slonik/src/connectionMethods/stream.ts

@@ -10,7 +10,6 @@ import type {
   StreamHandler,
 } from '../types.js';
 import type { DriverStreamResult } from '@slonik/driver';
-import { SlonikError } from '@slonik/errors';
 import { Transform } from 'node:stream';
 import { pipeline } from 'node:stream/promises';
 
@@ -148,29 +147,19 @@ export const stream: InternalStreamFunction = async (
   onStream,
   uid,
 ) => {
-  try {
-    const result = await executeQuery(
-      connectionLogger,
-      connection,
-      clientConfiguration,
-      slonikSql,
-      uid,
-      createExecutionRoutine(clientConfiguration, onStream),
-      true,
-    );
-
-    if (result.type === 'QueryResult') {
-      throw new Error(
-        'Query result cannot be returned in a streaming context.',
-      );
-    }
-
-    return result;
-  } catch (error) {
-    if (error instanceof SlonikError) {
-      connection.events.emit('error', error);
-    }
-
-    throw error;
+  const result = await executeQuery(
+    connectionLogger,
+    connection,
+    clientConfiguration,
+    slonikSql,
+    uid,
+    createExecutionRoutine(clientConfiguration, onStream),
+    true,
+  );
+
+  if (result.type === 'QueryResult') {
+    throw new Error('Query result cannot be returned in a streaming context.');
   }
+
+  return result;
 };

packages/slonik/src/routines/executeQuery.ts

@@ -711,6 +711,10 @@ export const executeQuery = async (
         stream,
       );
     } catch (error) {
+      if (error instanceof SlonikError) {
+        connection.events.emit('error', error);
+      }
+
       span.recordException(error);
       span.setStatus({
         code: SpanStatusCode.ERROR,