Repository navigation
Commit a7536fd
committed
fix(captions): pick the closest position preset, not the first one checked
activeHorizontalPositionPreset checked "is this centered?" before "is this
flush left/right?" — fine normally, but as width approaches 100 the whole
reachable range shrinks toward 0 right along with it, so a band sitting
exactly at the true left/right edge could fall inside the center check's
epsilon too and get reported as centered. Comparing all three candidates and
keeping the nearest one is correct regardless of how narrow the range gets.
Found via code review (CodeRabbit hit its OSS rate limit on the PR, so this
ran as a subagent review instead). Reachable today only through a hand-edited
or externally-generated project file — legacyEditor.captions has no schema
validation — not through the shipped integer-stepped width slider.1 parent 619057a commit a7536fd
2 files changed
Lines changed: 34 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
277 | 278 | | |
278 | 279 | | |
279 | 280 | | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
280 | 293 | | |
281 | 294 | | |
282 | 295 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
215 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
216 | 220 | | |
217 | 221 | | |
218 | 222 | | |
219 | 223 | | |
220 | 224 | | |
221 | 225 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
226 | 241 | | |
227 | 242 | | |
228 | 243 | | |
| |||
0 commit comments