Skip to content

Commit f1523d5

Browse files
committed
ci(release): restrict the 1.8.0 build to Windows
1.8.0 ships Windows-only, but publish-release gated on the macOS and Linux jobs, so either one failing would have blocked the release entirely. Disable both platform jobs and drop them from publish-release's needs - a skipped job in needs skips the dependent too, so gating alone is not enough. The Linux artifact download gets continue-on-error to match the macOS ones. Every hunk is marked RELEASE-BRANCH-ONLY: this must not ride along into main when promoting, or all later releases become Windows-only.
1 parent 1b9f66a commit f1523d5

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ jobs:
8989

9090
build-macos:
9191
name: macOS ${{ matrix.arch }} DMG
92+
# RELEASE-BRANCH-ONLY: 1.8.0 ships Windows-only. Do NOT let this `if: false`
93+
# reach main when promoting, or every later release becomes Windows-only too.
94+
if: false
9295
runs-on: macos-latest
9396
strategy:
9497
fail-fast: false
@@ -263,6 +266,8 @@ jobs:
263266

264267
build-linux:
265268
name: Linux packages
269+
# RELEASE-BRANCH-ONLY: see the note on build-macos above.
270+
if: false
266271
runs-on: ubuntu-latest
267272
steps:
268273
- name: Checkout code
@@ -298,10 +303,11 @@ jobs:
298303
publish-release:
299304
name: Publish GitHub release
300305
runs-on: ubuntu-latest
306+
# RELEASE-BRANCH-ONLY: build-macos / build-linux are disabled for this
307+
# Windows-only release. A skipped job in `needs` skips this one too, so they
308+
# must come out of the list, not just be gated. Restore all three on main.
301309
needs:
302310
- build-windows
303-
- build-macos
304-
- build-linux
305311
if: ${{ (github.event_name == 'push' && github.ref_type == 'tag') || (github.event_name == 'workflow_dispatch' && github.event.inputs.release_tag != '') }}
306312
steps:
307313
- name: Checkout code
@@ -383,6 +389,9 @@ jobs:
383389
path: artifacts/mac-x64
384390

385391
- name: Download Linux packages
392+
# RELEASE-BRANCH-ONLY: tolerate the missing artifact from the disabled
393+
# Linux job (the macOS downloads below already do). Drop with the rest.
394+
continue-on-error: true
386395
uses: actions/download-artifact@v4
387396
with:
388397
name: openscreen-linux

0 commit comments

Comments
 (0)