Skip to content

Commit 36e12ee

Browse files
authored
test(sveltekit): Pin rollup to 4.64.5 (#25328)
Pinning for now to unblock the CI. Will follow up on an actual fix for this. I'm still not sure where the fix should go.
1 parent b9cd12a commit 36e12ee

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

‎dev-packages/e2e-tests/test-applications/sveltekit-2-static/package.json‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@
1515
"test:assert": "pnpm test:prod && pnpm test:dev",
1616
"test:dev": "TEST_ENV=development playwright test db"
1717
},
18-
"//": "Need to use ioredis 5.10.1 because that's the last version before they support tracing channels",
18+
"//": [
19+
"Need to use ioredis 5.10.1 because that's the last version before they support tracing channels",
20+
"Rollup 4.64.6 keeps SvelteKit's Svelte 5 `$app/state` code in the Svelte 4 server build, which then throws `$state is not defined` on every page render"
21+
],
1922
"dependencies": {
2023
"@sentry/sveltekit": "file:../../packed/sentry-sveltekit-packed.tgz",
2124
"ioredis": "5.10.1",
@@ -33,6 +36,11 @@
3336
"typescript": "^5.0.0",
3437
"vite": "^5.4.11"
3538
},
39+
"pnpm": {
40+
"overrides": {
41+
"rollup": "4.64.5"
42+
}
43+
},
3644
"volta": {
3745
"extends": "../../package.json"
3846
},

‎dev-packages/e2e-tests/test-applications/sveltekit-2/package.json‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@
1515
"test:assert": "pnpm test:prod && pnpm test:dev",
1616
"test:dev": "TEST_ENV=development playwright test db"
1717
},
18-
"//": "Need to use ioredis 5.10.1 because that's the last version before they support tracing channels",
18+
"//": [
19+
"Need to use ioredis 5.10.1 because that's the last version before they support tracing channels",
20+
"Rollup 4.64.6 keeps SvelteKit's Svelte 5 `$app/state` code in the Svelte 4 server build, which then throws `$state is not defined` on every page render"
21+
],
1922
"dependencies": {
2023
"@sentry/sveltekit": "file:../../packed/sentry-sveltekit-packed.tgz",
2124
"ioredis": "5.10.1",
@@ -33,6 +36,11 @@
3336
"typescript": "^5.0.0",
3437
"vite": "^5.4.11"
3538
},
39+
"pnpm": {
40+
"overrides": {
41+
"rollup": "4.64.5"
42+
}
43+
},
3644
"volta": {
3745
"extends": "../../package.json"
3846
},

0 commit comments

Comments
 (0)