From 3321f619739a60708158d1c1cabe308abae13ec2 Mon Sep 17 00:00:00 2001 From: Dan Gold Date: Thu, 17 Sep 2026 17:06:41 -0700 Subject: [PATCH] ci: stop the smoke test asserting on page copy The title changed from "Orbital" to "Sentry Live" in #35 and the smoke test was grepping for Orbital, so master went red on a wording change. Assert on the mount point instead. The step's own comment says the point is "the built frontend, not a bare index" -- id="root" is exactly that, and it does not move when copy does. The bundle checks below already do the real work of proving the asset is in the image and served. Also assert that public/ survives the build into the image. Nothing covered the favicons, the manifest or the social card, so they could have stopped being copied without turning anything red. Verified against the built container: every check passes and the old assertion fails as reported. --- .github/workflows/build.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 791432f..1762d00 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -64,10 +64,17 @@ jobs: curl -sf http://localhost:7000/stats | grep -q 'udp_received' || (echo "stats missing udp_received" && exit 1) # / must return 200 and be the built frontend, not a bare index: # the asset it names has to be in the image and served too. - curl -sf http://localhost:7000/ | grep -q 'Orbital' || (echo "index page missing expected content" && exit 1) + # Assert on the mount point rather than the title -- the title is copy, + # and asserting on copy means every wording change is a red build. + curl -sf http://localhost:7000/ | grep -q 'id="root"' || (echo "index page is not the built frontend" && exit 1) ASSET=$(curl -sf http://localhost:7000/ | grep -o '/assets/index-[^"]*\.js' | head -1) [ -n "$ASSET" ] || (echo "index page names no built bundle" && exit 1) curl -sfI "http://localhost:7000$ASSET" > /dev/null || (echo "bundle $ASSET not served" && exit 1) + # public/ has to survive the build into the image: nothing else would + # catch the favicons and the social card quietly going missing. + for f in /favicon.ico /favicon.svg /og-v1.png /site.webmanifest; do + curl -sfI "http://localhost:7000$f" > /dev/null || (echo "static asset $f not served" && exit 1) + done docker stop orbital-smoke - name: Push to GHCR