Repository navigation
Commit 0e122f4
committed
fix(ruby): Keep running the job when scope data cannot be applied
hook_hash only coerces the top-level value scope_data returns, and
apply_scope_data ran outside safely. A tags, extra, user or context value
that is not a Hash made the Scope setters raise ArgumentError from
start_job, so the job never ran. Apply the scope data through safely,
as the other hooks are, so the failure is logged and the job runs.1 parent a6b58ce commit 0e122f4
2 files changed
Lines changed: 11 additions & 1 deletion
File tree
- sentry-ruby
- lib/sentry/job_extensions
- spec/sentry/job_extensions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
280 | 289 | | |
281 | 290 | | |
282 | 291 | | |
| |||
0 commit comments