Repository navigation
Commit 862a0ff
fix(redis): Do not record credentials from AUTH and admin commands (#3189)
* fix(redis): Do not record AUTH and HELLO arguments
The Redis formatter always recorded the second command element as the key,
so AUTH <password> put the password into span descriptions and breadcrumbs
regardless of data collection settings. HELLO's AUTH arguments were recorded
whenever database query data collection was enabled.
Record only the command name for these commands.
Resolves SDK-1226
Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
* fix(redis): Do not record arguments of admin commands
With database query data collection enabled, admin commands recorded all
arguments, including credentials from CONFIG SET requirepass, ACL SETUSER,
MIGRATE ... AUTH and SENTINEL SET ... auth-pass.
Record only the command and subcommand for ACL, CONFIG, MIGRATE and
SENTINEL.
Refs SDK-1226
Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
* fix comments
---------
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
Co-authored-by: Johannes Daxböck <johannes.daxboeck@sentry.io>1 parent a62cf84 commit 862a0ff
2 files changed
Lines changed: 42 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
| 67 | + | |
| 68 | + | |
63 | 69 | | |
64 | 70 | | |
65 | | - | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
35 | 70 | | |
36 | 71 | | |
37 | 72 | | |
| |||
0 commit comments