Skip to content

Commit b6c17eb

Browse files
gitcommit90claude
andauthored
fix(phase4): make Linux acceptance failures legible (#76)
Many Linux acceptance checks are bare `[[ ... ]]` or `--quiet` assertions that exit non-zero with no output. When one fails, the only signal is "Process completed with exit code 1" with no indication of which check failed, forcing a full candidate rerun to learn anything. Add an ERR trap that prints the exact line number and failing command as a GitHub error annotation, so a failing candidate is diagnosable from the log alone. No behavior change on success; existing guarded checks keep their own messages. Co-authored-by: Joseph Yaksich <gitcommit90@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
1 parent 5c23cdc commit b6c17eb

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎ops/platform-acceptance/linux.sh‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
#!/usr/bin/env bash
22
set -euo pipefail
33

4+
# Many acceptance checks are bare `[[ ... ]]` or `--quiet` assertions that exit
5+
# non-zero with no output, so a failure surfaces only as "exit code 1" with no
6+
# clue which check failed. Report the exact line and command instead, so a
7+
# failing candidate is diagnosable from the log alone rather than by rerunning.
8+
trap 'status=$?; echo "::error::Linux acceptance failed at line ${LINENO} (exit ${status}): ${BASH_COMMAND}" >&2' ERR
9+
410
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
511
ARCHIVE="${HELM_CANDIDATE_ARCHIVE:?exact Linux candidate archive is required}"
612
OFFLINE_ARCHIVE="${HELM_CANDIDATE_OFFLINE_ARCHIVE:?exact Linux offline candidate archive is required}"

0 commit comments

Comments
 (0)