This repository was archived by the owner on Sep 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Move release drafter config to earlier step #97
Copy link
Copy link
Open
Labels
Description
This is just a suggestion, not sure if I'm on board with it.
It seems that Step: adding a feature, isn't really asking the learner to make a meaningful change:
Lines 94 to 118 in d1ba8ec
| #4 - User makes a change and opens a pull request against `base: release-v1.0` | |
| - title: Adding a feature | |
| description: Update the README.md and open a pull request. | |
| event: pull_request.opened | |
| link: '{{ repoUrl }}/issues/3' | |
| actions: | |
| # We make sure that the user's pull request has the base set to `release-v1.0` | |
| - type: gate | |
| left: '%payload.pull_request.base.ref%' | |
| operator: === | |
| right: 'release-v1.0' | |
| # If the user opened a pull request to master instead... | |
| else: | |
| # we comment and tell them that they should try again | |
| - type: respond | |
| with: 05.1_wrong-base.md | |
| issue: '%payload.pull_request.number%' | |
| # TODO: reduce possible extra PRs by allowing learner to change the base instead of closing PR | |
| # and we close the pull request, unmerged | |
| - type: closeIssue | |
| issue: '%payload.pull_request.number%' | |
| # We approve their pull request | |
| - type: createReview | |
| body: 05.2_approval.md | |
| event: APPROVE |
Since we need the learner to add the config for release drafter anyway, perhaps we can suggest that change instead of the current extra step:
Lines 261 to 274 in d1ba8ec
| #9 - Merge the release drafter configuration | |
| - title: Merge the config for release drafter | |
| description: Merge the configuration file for release drafter, which sets a template for the release. | |
| event: pull_request.closed | |
| link: '{{ repoUrl }}/pull/8' | |
| actions: | |
| - type: respond | |
| with: 09.2_goto-release.md | |
| data: | |
| url: '6' | |
| - type: createReview | |
| body: 09.1_response.md | |
| event: APPROVE | |
| number: 6 |