Merge pull request #3319 from glideapps/fix/objective-c-array-size-constraints

Objective-C: validate array size constraints

Author: schani

packages/quicktype-core/src/language/Objective-C/ObjectiveCRenderer.ts

@@ -6,7 +6,10 @@ import {
     mapSome,
 } from "collection-utils";
 
-import { minMaxValueForType } from "../../attributes/Constraints.js";
+import {
+    minMaxItemsForType,
+    minMaxValueForType,
+} from "../../attributes/Constraints.js";
 import {
     ConvenienceRenderer,
     type ForbiddenWordsInfo,
@@ -873,6 +876,18 @@ export class ObjectiveCRenderer extends ConvenienceRenderer {
                                         `if (dict[@"${objectiveCStringEscape(jsonName)}"] && [dict[@"${objectiveCStringEscape(jsonName)}"] doubleValue] > ${max}) return nil;`,
                                     );
                                 }
+                                const [minItems, maxItems] =
+                                    minMaxItemsForType(property.type) ?? [];
+                                if (minItems !== undefined) {
+                                    this.emitLine(
+                                        `if (dict[@"${objectiveCStringEscape(jsonName)}"] && [(NSArray *)dict[@"${objectiveCStringEscape(jsonName)}"] count] < ${minItems}) return nil;`,
+                                    );
+                                }
+                                if (maxItems !== undefined) {
+                                    this.emitLine(
+                                        `if ([(NSArray *)dict[@"${objectiveCStringEscape(jsonName)}"] count] > ${maxItems}) return nil;`,
+                                    );
+                                }
                                 if (
                                     !property.isOptional &&
                                     property.type.isNullable

test/languages.ts

@@ -927,7 +927,13 @@ export const ObjectiveCLanguage: Language = {
     diffViaSchema: false,
     skipDiffViaSchema: [],
     allowMissingNull: true,
-    features: ["enum", "minmax", "minmaxInteger", "strict-optional"],
+    features: [
+        "enum",
+        "minmax",
+        "minmaxInteger",
+        "minmaxitems",
+        "strict-optional",
+    ],
     output: "QTTopLevel.m",
     topLevel: "QTTopLevel",
     skipJSON: [