feat(gooddata-sdk): [AUTO] add CatalogCustomGeoCollection wrappers with name and description fields#1343
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
Conversation
…DeclarativeCustomGeoCollection wrappers Adds SDK wrapper classes and service methods for the CustomGeoCollection entity and DeclarativeCustomGeoCollection layout model, including optional name and description fields, CRUD service methods, and test fixtures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SDK wrappers for CustomGeoCollection entity and DeclarativeCustomGeoCollection layout model, exposing the new optional
nameanddescriptionfields added in gdc-nas.P012 | https://github.com/gooddata/gdc-nas/actions/runs/22176850727
gdc-nas Changes
Commit e208d68 (Merge PR #20263) added optional
name(VARCHAR 255) anddescription(VARCHAR 10000) fields to bothCustomGeoCollectionentity model andDeclarativeCustomGeoCollectionlayout model in metadata-api. Includes DB migration (Liquibase changesetcustom-geo-collection-name-description), repository mapping updates (OrganizationTables.kt,OrganizationMapping.kt,OrganizationLayout.kt), and OpenAPI spec regeneration (JsonApiCustomGeoCollectionIn/Out/Patch,DeclarativeCustomGeoCollectionschemas).SDK Implementation
New wrapper classes and service methods created:
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/custom_geo_collection.py(NEW) —CatalogCustomGeoCollectionwrapper class with optionalnameanddescriptionfields,from_api_model/as_api_modelserializationpackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/layout/custom_geo_collection.py(NEW) —CatalogDeclarativeCustomGeoCollectionwrapper class for layout modelpackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.py— Added 6 service methods:list_custom_geo_collections,get_custom_geo_collection,create_custom_geo_collection,delete_custom_geo_collection,get_custom_geo_collections_layout,set_custom_geo_collectionspackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/__init__.py— ExportCatalogCustomGeoCollectionpackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/layout/__init__.py— ExportCatalogDeclarativeCustomGeoCollectionpackages/gooddata-sdk/src/gooddata_sdk/__init__.py— Top-level exports addedpackages/gooddata-sdk/tests/catalog/test_catalog_organization.py— New test functionspackages/gooddata-sdk/tests/catalog/fixtures/organization/create_custom_geo_collection.yaml(NEW) — VCR cassette fixturepackages/gooddata-sdk/tests/catalog/fixtures/organization/layout_custom_geo_collections.yaml(NEW) — VCR cassette fixtureJIRA: DX-PENDING (https://gooddata-sandbox.atlassian.net)
Risk: Low