feat(gooddata-sdk): [AUTO] add deployment info fields to CatalogOrganization#1347
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] add deployment info fields to CatalogOrganization#1347yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…ization Add 'data_center' and 'region' optional nullable string fields to CatalogOrganizationAttributes and extract them in CatalogOrganization.from_api() from the API response. Both fields are read-only (ApiOutOnly) and gated by the ENABLE_DEPLOYMENT_INFO feature flag on the server side. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose new read-only deployment info fields ('region' and 'dataCenter') on CatalogOrganization by updating the SDK wrapper to extract these fields from the API response.
P009 | https://github.com/gooddata/gdc-nas/actions/runs/22181963264
Caution
Test fixtures were modified. Manually edited fixtures may not match real API responses.
Re-record these fixtures against a live server before merging:
packages/gooddata-sdk/tests/catalog/fixtures/organization/organization.yamlWhat changed in gdc-nas
Commit f0f3783 added two new read-only deployment info fields to the Organization model in
metadata-modeland exposed them viametadata-api:regionfield (nullable String,@ApiOutOnly) — description: "Current deployment cluster name", maps fromgdc.deploymentInfo.clusterNameconfigdataCenterfield (nullable String,@ApiOutOnly) — description: "Current deployment region", maps fromgdc.deploymentInfo.regionconfigBoth fields are gated by the
ENABLE_DEPLOYMENT_INFOfeature flag. Thegooddata-api-clienthas already been regenerated to exposedata_centerandregionas optional nullable fields onJsonApiOrganizationOutAttributes.What was implemented in SDK
data_center: Optional[str] = Noneandregion: Optional[str] = Nonefields toCatalogOrganizationAttributesCatalogOrganization.from_api()to extract both fields from the API response attributes (fields are@ApiOutOnlyso noas_api_model()changes required)organization.yamlto include the new nullable fields in the recorded responsetest_catalog_organization.pyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/organization.pypackages/gooddata-sdk/tests/catalog/fixtures/organization/organization.yamlpackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low