feat(gooddata-sdk): [AUTO] add allowed_relationship_types to ai_chat, ai_chat_stream, and search_ai#1349
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
Conversation
… ai_chat_stream, and search_ai Expose the new allowedRelationshipTypes field from the regenerated API client in ComputeService methods ai_chat(), ai_chat_stream(), and search_ai(). Also re-export AllowedRelationshipType from gooddata_sdk.__init__ so SDK consumers can construct filter objects without importing from the generated client directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the new
allowedRelationshipTypesfield in theComputeServicewrapper methods so SDK consumers can restrict which workspace object relationship types the GenAI service may reference when filtering search results.Problem: P004 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22181963264
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/compute/fixtures/ai_chat_with_allowed_relationship_types.yamlpackages/gooddata-sdk/tests/compute/fixtures/ai_chat_stream_with_allowed_relationship_types.yamlpackages/gooddata-sdk/tests/compute/fixtures/ai_search_with_allowed_relationship_types.yamlWhat changed in gdc-nas
PR #20108 (merge commit 85777a0) added:
allowedRelationshipTypes: List<AllowedRelationshipType>?field toChatRequestKotlin model and OpenAPI specGenAIProcessorto the gRPC proto (repeated AllowedRelationshipType allowed_relationship_types = 26ingen_ai.proto)relationship_filter.pydomain module in the gen-ai Python service, invoked fromSearchRequestHandlerandSearchServicegooddata-api-clientwas already regenerated to includeAllowedRelationshipTypemodel and the new field inChatRequest/SearchRequestRelated Jira: GDAI-1166, GDAI-1089, QA-26995
What was implemented in SDK
allowed_relationship_types: Optional[list[AllowedRelationshipType]] = Noneparameter toai_chat(),ai_chat_stream(), andsearch_ai()inComputeService, forwarding it to the underlyingChatRequest/SearchRequestAPI client modelsAllowedRelationshipType(fromgooddata_api_client.model.allowed_relationship_type) is now imported inservice.pyand re-exported fromgooddata_sdk.__init__so SDK consumers can construct filter objects without reaching into the generated client packagetest_compute_service.pycovering the new parameter in each affected methodFiles modified
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_compute_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low