IAM Provision Token: allow joins by AWS Organization (proto) #62022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
marcoandredinis
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
mmcallister,
ptgott,
r0mant,
tigrato and
zmb3
|
Amplify deployment status
|
hugoShaka
approved these changes
Dec 5, 2025
Comment on lines
+1493
to
+1494
| // AWSOrganizationID is used for the IAM join method, the AWS identity of joining nodes | ||
| // must belong to this organization. |
Contributor
There was a problem hiding this comment.
nit: can you add a "Not implemented yet." In the godoc if you are planning to backport this now? You can disregard this comment if you're planning to backport all PRs at the same time.
This will prevent the field from landing in the resource reference and people trying to use it while it has no effect.
Similarly, when you're done backporting the feature to v18, it would be nice to add "Requires version 18.x.y" to the godoc.
Contributor
Author
There was a problem hiding this comment.
I'll skip for now and only add the released in/requires version as I'm closing to merge the PR in v18
bernardjkim
approved these changes
Dec 5, 2025
public-teleport-github-review-bot
bot
removed request for
mmcallister,
ptgott,
r0mant,
tigrato and
zmb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have hundreds of AWS Accounts and add/remove them with high frequency.
In order to allow them to set a single IAM Join Token which allows any node to join the cluster as long as it is part of an account which belongs to an Organization, the IAM Join Token is changed so that we are able to filter which AWS Organizations can join the cluster.