Allow more info dialog navigation through external bus #4056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes use of external bus navigation to allow more info dialogs to be opened without needing to refresh webview
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables more info dialogs to be opened using external bus navigation instead of requiring a full WebView reload. The change adds version detection to determine when the frontend supports this capability, allowing for smoother navigation when opening entity more info dialogs.
Key Changes:
- Adds a new version constant
canNavigateMoreInfoDialogThroughFrontend(2026.1) to track frontend feature support - Updates
openPanel()logic to use external bus navigation for more info dialogs when the frontend version supports it - Maintains backward compatibility by falling back to direct URL loading for older frontend versions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Shared/Environment/AppConstants.swift | Adds version constant to track when frontend supports more info dialog navigation via external bus |
| Sources/App/WebView/WebViewController.swift | Updates guard condition to allow external bus navigation for more info dialogs when frontend version supports it |
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
+ Coverage 44.72% 45.66% +0.94%
==========================================
Files 232 242 +10
Lines 13911 13611 -300
==========================================
- Hits 6221 6216 -5
+ Misses 7690 7395 -295 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of external bus navigation to allow more info dialogs to be opened without needing to refresh webview
Depends on: home-assistant/frontend#28375
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes