fix: disable CGO for all npm builds and improve test coverage

- Set CGO_ENABLED=0 for all platform builds (Darwin, Linux, Windows)
  since the codebase is pure Go with no C dependencies
- Remove unnecessary mingw cross-compiler dependencies from CI
- Fix wrapper script error handling: use ?? instead of || for
  proper null status handling
- Enhance test-npm-build.sh with:
  - Verification of all 6 platform binaries (was only checking 2)
  - Binary architecture validation using 'file' command
  - Exit code propagation test for wrapper script

The codebase has no CGO imports, so CGO_ENABLED=0 is the accurate
setting for cross-compilation. This simplifies the build process
and removes the need for platform-specific cross-compilers.

See #202 for discussion on Windows 32-bit support.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: leggetter

.github/workflows/release.yml

@@ -140,11 +140,6 @@ jobs:
         with:
           go-version: 1.24.9
 
-      - name: Install Windows cross-compilation tools
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y gcc-mingw-w64-x86-64
-
       - name: Build npm binaries with GoReleaser
         uses: goreleaser/goreleaser-action@v5
         with:

.github/workflows/test-npm-build.yml

@@ -12,28 +12,23 @@ jobs:
     steps:
       - name: Code checkout
         uses: actions/checkout@v4
-      
+
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.24.9
-      
-      - name: Install Windows cross-compilation tools
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y gcc-mingw-w64-x86-64
-      
+
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
           node-version: "20.x"
-      
+
       - name: Install GoReleaser
         uses: goreleaser/goreleaser-action@v5
         with:
           version: v2.10.2
           install-only: true
-      
+
       - name: Run npm build tests
         run: |
           chmod +x test-scripts/test-npm-build.sh

.goreleaser/npm.yml

@@ -7,14 +7,14 @@ before:
     - go generate ./...
 project_name: hookdeck
 builds:
-  # Darwin builds
+  # Darwin builds (CGO disabled for cross-compilation from Ubuntu)
   - id: npm-darwin-amd64
     binary: hookdeck
     main: ./main.go
     goos: [darwin]
     goarch: [amd64]
     env:
-      - CGO_ENABLED=1
+      - CGO_ENABLED=0
     ldflags:
       - -s -w -X github.com/hookdeck/hookdeck-cli/pkg/version.Version={{.Version}}
     hooks:
@@ -28,6 +28,8 @@ builds:
     main: ./main.go
     goos: [darwin]
     goarch: [arm64]
+    env:
+      - CGO_ENABLED=0
     ldflags:
       - -s -w -X github.com/hookdeck/hookdeck-cli/pkg/version.Version={{.Version}}
     hooks:
@@ -67,16 +69,14 @@ builds:
         - cp "{{ .Path }}" binaries/linux-arm64/hookdeck
         - chmod +x binaries/linux-arm64/hookdeck
 
-  # Windows builds
+  # Windows builds (CGO disabled - codebase is pure Go)
   - id: npm-windows-amd64
     binary: hookdeck
     main: ./main.go
     goos: [windows]
     goarch: [amd64]
     env:
-      - CGO_ENABLED=1
-      - CC=x86_64-w64-mingw32-gcc
-      - CXX=x86_64-w64-mingw32-g++
+      - CGO_ENABLED=0
     ldflags:
       - -s -w -X github.com/hookdeck/hookdeck-cli/pkg/version.Version={{.Version}}
     hooks:
@@ -90,9 +90,7 @@ builds:
     goos: [windows]
     goarch: [386]
     env:
-      - CGO_ENABLED=1
-      - CC=x86_64-w64-mingw32-gcc
-      - CXX=x86_64-w64-mingw32-g++
+      - CGO_ENABLED=0
     ldflags:
       - -s -w -X github.com/hookdeck/hookdeck-cli/pkg/version.Version={{.Version}}
     hooks:

bin/hookdeck.js

@@ -33,5 +33,5 @@ try {
 } catch (error) {
   // execFileSync will exit with the same code as the binary
   // If there's an error executing, exit with code 1
-  process.exit(error.status || 1);
+  process.exit(error.status ?? 1);
 }

test-scripts/test-npm-build.sh

@@ -38,25 +38,86 @@ for dir in "${expected_dirs[@]}"; do
     fi
 done
 
-# Verify binaries exist
-echo "Verifying binaries exist..."
-if [ ! -f "binaries/darwin-amd64/hookdeck" ]; then
-    echo "Error: Missing binary: binaries/darwin-amd64/hookdeck"
-    exit 1
-fi
-if [ ! -f "binaries/win32-amd64/hookdeck.exe" ]; then
-    echo "Error: Missing binary: binaries/win32-amd64/hookdeck.exe"
-    exit 1
-fi
+# Verify all binaries exist
+echo "Verifying all binaries exist..."
+expected_binaries=(
+    "binaries/darwin-amd64/hookdeck"
+    "binaries/darwin-arm64/hookdeck"
+    "binaries/linux-amd64/hookdeck"
+    "binaries/linux-arm64/hookdeck"
+    "binaries/win32-amd64/hookdeck.exe"
+    "binaries/win32-386/hookdeck.exe"
+)
+
+for binary in "${expected_binaries[@]}"; do
+    if [ ! -f "$binary" ]; then
+        echo "Error: Missing binary: $binary"
+        exit 1
+    fi
+    echo "✓ Found: $binary"
+done
+
+# Verify binary architectures using 'file' command
+echo ""
+echo "Verifying binary architectures..."
+
+verify_binary_arch() {
+    local binary="$1"
+    local expected_pattern="$2"
+    local description="$3"
+    
+    file_output=$(file "$binary")
+    if echo "$file_output" | grep -q "$expected_pattern"; then
+        echo "✓ $description: $file_output"
+    else
+        echo "✗ $description: Expected '$expected_pattern' but got:"
+        echo "  $file_output"
+        exit 1
+    fi
+}
+
+# Darwin binaries
+verify_binary_arch "binaries/darwin-amd64/hookdeck" "Mach-O 64-bit.*x86_64" "darwin-amd64"
+verify_binary_arch "binaries/darwin-arm64/hookdeck" "Mach-O 64-bit.*arm64" "darwin-arm64"
+
+# Linux binaries
+verify_binary_arch "binaries/linux-amd64/hookdeck" "ELF 64-bit.*x86-64" "linux-amd64"
+verify_binary_arch "binaries/linux-arm64/hookdeck" "ELF 64-bit.*ARM aarch64" "linux-arm64"
+
+# Windows binaries - PE32 is 32-bit, PE32+ is 64-bit
+verify_binary_arch "binaries/win32-amd64/hookdeck.exe" "PE32+ executable.*x86-64" "win32-amd64 (64-bit)"
+verify_binary_arch "binaries/win32-386/hookdeck.exe" "PE32 executable.*Intel 80386" "win32-386 (32-bit)"
+
+echo ""
+echo "✓ All binary architectures verified!"
 
 # Test wrapper script on current platform
+echo ""
 echo "Testing wrapper script on current platform..."
 if node bin/hookdeck.js --version > /dev/null 2>&1; then
     echo "✓ Wrapper script works on $(uname -s)-$(uname -m)"
 else
     echo "⚠ Warning: Wrapper script test skipped (binary may not exist for this platform)"
 fi
 
+# Test wrapper script exit code handling
+echo ""
+echo "Testing wrapper script exit code handling..."
+
+# Test that wrapper propagates non-zero exit codes correctly
+# Run an invalid command that will cause the binary to exit with non-zero
+set +e  # Temporarily disable exit on error
+node bin/hookdeck.js invalid-command-that-does-not-exist > /dev/null 2>&1
+EXIT_CODE=$?
+set -e  # Re-enable exit on error
+
+if [ $EXIT_CODE -ne 0 ]; then
+    echo "✓ Wrapper script correctly propagates non-zero exit code ($EXIT_CODE)"
+else
+    echo "✗ Wrapper script should have returned non-zero exit code for invalid command"
+    exit 1
+fi
+
 # Test npm pack
 echo "Testing npm pack..."
 npm pack --dry-run > /tmp/npm-pack-output.txt 2>&1