fix: treat 410 Gone as not-found

Hookdeck may return 410 for deleted resources; classify it as not-found to keep deletion UX and tests consistent.

Made-with: Cursor

Author: leggetter

pkg/gateway/mcp/errors.go

@@ -20,7 +20,7 @@ func TranslateAPIError(err error) string {
 	switch apiErr.StatusCode {
 	case http.StatusUnauthorized:
 		return "Authentication failed. Check your API key."
-	case http.StatusNotFound:
+	case http.StatusNotFound, http.StatusGone:
 		return fmt.Sprintf("Resource not found: %s", apiErr.Message)
 	case http.StatusUnprocessableEntity:
 		// Validation errors — pass through the API message directly.

pkg/gateway/mcp/server_test.go

@@ -244,6 +244,7 @@ func TestTranslateAPIError(t *testing.T) {
 	}{
 		{"401 Unauthorized", &hookdeck.APIError{StatusCode: 401, Message: "bad key"}, "Authentication failed"},
 		{"404 Not Found", &hookdeck.APIError{StatusCode: 404, Message: "resource xyz"}, "Resource not found"},
+		{"410 Gone", &hookdeck.APIError{StatusCode: 410, Message: "resource xyz"}, "Resource not found"},
 		{"422 Validation", &hookdeck.APIError{StatusCode: 422, Message: "invalid field foo"}, "invalid field foo"},
 		{"429 Rate Limit", &hookdeck.APIError{StatusCode: 429, Message: "slow down"}, "Rate limited"},
 		{"500 Server Error", &hookdeck.APIError{StatusCode: 500, Message: "internal"}, "Hookdeck API error"},

pkg/hookdeck/client.go

@@ -108,10 +108,12 @@ func (e *APIError) Error() string {
 	return fmt.Sprintf("unexpected http status code: %d", e.StatusCode)
 }
 
-// IsNotFoundError reports whether the error is an API 404 Not Found response.
+// IsNotFoundError reports whether the error is an API "not found" response.
+// Hookdeck may return 404 (Not Found) or 410 (Gone) for resources that have
+// been deleted.
 func IsNotFoundError(err error) bool {
 	var apiErr *APIError
-	return errors.As(err, &apiErr) && apiErr.StatusCode == http.StatusNotFound
+	return errors.As(err, &apiErr) && (apiErr.StatusCode == http.StatusNotFound || apiErr.StatusCode == http.StatusGone)
 }
 
 // PerformRequest sends a request to Hookdeck and returns the response.

pkg/hookdeck/client_test.go

@@ -13,6 +13,11 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestIsNotFoundError_410Gone(t *testing.T) {
+	require.True(t, IsNotFoundError(&APIError{StatusCode: http.StatusGone, Message: "gone"}))
+	require.False(t, IsNotFoundError(&APIError{StatusCode: http.StatusInternalServerError, Message: "err"}))
+}
+
 func TestPerformRequest_ParamsEncoding_Delete(t *testing.T) {
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		require.Equal(t, "/delete", r.URL.Path)