Skip to content

Inverse equality in DeploymentInfo #10

Description

@marcingrzejszczak

In https://github.com/hpcloud/cloudfoundry-jenkins/blob/master/src/main/java/com/hpe/cloudfoundryjenkins/DeploymentInfo.java your checking for equality to "" like this:

 this.command = jenkinsConfig.command;
        if (command.equals("")) {
            command = null;
        }

You should inverse the check like this

 this.command = jenkinsConfig.command;
        if ("".equals(command)) {
            command = null;
        }

Cause otherwise you will cause NPEs (which I'm getting)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions