Skip to content

Adding filters to deriviatives.md and resolves.md#427

Merged
pulsipher merged 2 commits into
infiniteopt:masterfrom
dnguyen227:resolves_doc_fix
May 12, 2026
Merged

Adding filters to deriviatives.md and resolves.md#427
pulsipher merged 2 commits into
infiniteopt:masterfrom
dnguyen227:resolves_doc_fix

Conversation

@dnguyen227
Copy link
Copy Markdown
Contributor

Summary

This PR fixes/implements the following bugs/features

Doctest fragility — incidental integers (source line numbers, solver iteration counts) break doctests on version drift

The doctest in docs/src/guide/derivative.md filters on a hardcoded line number (scalar_parameters.jl:807), which fails whenever that source line shifts. Two jldoctest quick blocks in docs/src/tutorials/resolves.md also assert exact barrier_iterations counts that depend on the Ipopt build.

The fix replaces the line-specific filter with r"\d+" in derivative.md's DocTestFilters, and adds ; filter = r"\d+" to the two affected blocks in resolves.md — 3 lines total.

Closing issues

Fixes #426

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.77%. Comparing base (ca087ad) to head (f824822).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          38       38           
  Lines        6588     6588           
=======================================
  Hits         6573     6573           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@pulsipher pulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pulsipher pulsipher merged commit 052ecbb into infiniteopt:master May 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doctests fail on incidental integer drift (line numbers, solver iterations)

2 participants