Adding filters to deriviatives.md and resolves.md#427
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 38 38
Lines 6588 6588
=======================================
Hits 6573 6573
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
Doctest fragility — incidental integers (source line numbers, solver iteration counts) break doctests on version drift
The doctest in
docs/src/guide/derivative.mdfilters on a hardcoded line number (scalar_parameters.jl:807), which fails whenever that source line shifts. Twojldoctest quickblocks indocs/src/tutorials/resolves.mdalso assert exactbarrier_iterationscounts that depend on the Ipopt build.The fix replaces the line-specific filter with
r"\d+"inderivative.md'sDocTestFilters, and adds; filter = r"\d+"to the two affected blocks inresolves.md— 3 lines total.Closing issues
Fixes #426