Don't include deleted groups in widget generation

If a group was previously subscribed to the widget, we shouldn't
generate content for it.  We should properly update widgets
when groups are removed but for now, this allows the content generator
to work with widgets having orphaned group references.

Extracted from ManageIQ#23404

CP4AIOPS-15687

Author: jrafanie

app/models/miq_widget.rb

@@ -407,6 +407,7 @@ def grouped_subscribers
     groups_by_id    = MiqGroup.in_my_region.where(:id => grouped_users.keys).index_by(&:id)
     users_by_userid = User.in_my_region.where(:userid => grouped_users.values.flatten.uniq).index_by(&:userid)
     grouped_users.each_with_object({}) do |(k, v), h|
+      next unless groups_by_id.key?(k)
       user_objs = users_by_userid.values_at(*v).reject(&:blank?)
       h[groups_by_id[k]] = user_objs if user_objs.present?
     end

spec/models/miq_widget_spec.rb

@@ -177,6 +177,13 @@
           expect(result[@group1]).to match_array([@user1])
         end
 
+        it 'ignores a group that no longer exists' do
+          @user1.update(:miq_groups => [@group2])
+          @group1.destroy
+          result = @widget_report_vendor_and_guest_os.reload.grouped_subscribers
+          expect(result.size).to eq(0)
+        end
+
         it 'ignores the group that has no members' do
           @user1.delete
           result = @widget_report_vendor_and_guest_os.grouped_subscribers
@@ -300,8 +307,8 @@ def add_dashboard_for_user(db_name, userid, group)
       MiqReport.seed_report("Top CPU Consumers weekly")
 
       role1 = FactoryBot.create(:miq_user_role, :name => 'EvmRole-support')
-      group1 = FactoryBot.create(:miq_group, :description => "EvmGroup-support", :miq_user_role => role1)
-      user1  = FactoryBot.create(:user, :miq_groups => [group1])
+      @group1 = FactoryBot.create(:miq_group, :description => "EvmGroup-support", :miq_user_role => role1)
+      user1  = FactoryBot.create(:user, :miq_groups => [@group1])
 
       @user2  = FactoryBot.create(:user_admin)
       @group2 = @user2.current_group
@@ -332,7 +339,7 @@ def add_dashboard_for_user(db_name, userid, group)
         read_only: true
       ')
 
-      ws1 = FactoryBot.create(:miq_widget_set, :name => "default", :userid => user1.userid, :owner => group1)
+      ws1 = FactoryBot.create(:miq_widget_set, :name => "default", :userid => user1.userid, :owner => @group1)
       ws2 = FactoryBot.create(:miq_widget_set, :name => "default", :userid => @user2.userid, :owner => @group2)
 
       @widget = MiqWidget.sync_from_hash(attrs)
@@ -407,6 +414,17 @@ def add_dashboard_for_user(db_name, userid, group)
       expect(task_id).to be_nil
     end
 
+    it "does not generate content for a deleted group" do
+      @widget.visibility[:roles] = "_ALL_"
+      @group2.delete
+
+      expect(@widget).to receive(:queue_generate_content_for_users_or_group).with("MiqGroup", @group1.description, any_args).once
+      task_id = @widget.queue_generate_content
+
+      expect(MiqTask.count).to eq(1)
+      expect(task_id).to eq(MiqTask.first.id)
+    end
+
     it "does not generate content if content_type of widget is 'menu'" do
       @widget.update(:content_type => "menu")
       expect(@widget).not_to receive(:queue_generate_content_for_users_or_group)