webhook_challenge crashes — uses Request class instead of request instance

[themavik]

api/routes/alerts.py:621 calls Request.query_params.get("token") on the Starlette Request class, not an instance. The function has no request parameter. query_params is an instance property, so calling .get() on the class raises AttributeError.

The Netdata webhook challenge endpoint fails on every request because of this.

[dosubot]

Good catch! You're correct — the webhook_challenge function has a bug where it references Request.query_params.get("token") on the class instead of an instance.

The function is defined with no parameters:

async def webhook_challenge():
    token = Request.query_params.get("token").encode("ascii")

The fix would be to add request: Request as a parameter:

async def webhook_challenge(request: Request):
    token = request.query_params.get("token").encode("ascii")

This will let FastAPI inject the actual request instance, giving access to query_params.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[themavik]

yeah exactly. happy to send a PR for this if you want.