feat: added support for Podman as container engine#96
Open
Linsner wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
requested changes
Jun 8, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
This looks clean and straightforward, just rename BUILDER_ENGINE to CONTAINER_ENGINE please for clarity
| local BUILDER_CONFIGURATION="release" | ||
| local FILE= | ||
| local TARGET=. | ||
| echo $CONTAINER_ENGINE |
Member
There was a problem hiding this comment.
You have CONTAINER_ENGINE here but BUILDER_ENGINE elsewhere.
Do we need to echo this here?
Suggested change
| echo $CONTAINER_ENGINE |
(I prefer CONTAINER_ENGINE -- it's clearer)
| fi | ||
| if [[ $# -ge 4 ]]; then | ||
| TARGET="-f $4 ." | ||
| FILE="-f $4 " |
Member
There was a problem hiding this comment.
This may need additional tweaks later for api.keyman.com which has two Dockerfiles (one for db, one for site).
Comment on lines
+65
to
+68
| elif [[ "${CONTAINER_ENGINE}" == "docker" ]]; then | ||
| FILE="-f Dockerfile " | ||
| elif [[ "${CONTAINER_ENGINE}" == "podman" ]]; then | ||
| FILE="-f Podmanfile " |
Member
There was a problem hiding this comment.
Are these really needed? Won't podman use Podmanfile by default just as docker uses Dockerfile by default?
Member
|
Test-bot: skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.