Skip to content

Deprecate and rename the accept_untrusted_content=False keyword #46

Description

@rneilson

The accept_untrusted_content=False keyword in Receiver() and Sender.receive() is somewhat misleading, and has caused some confusion about its intended usage (see discussion in #24, #40, and #43).

I see two possibilities:

  1. Rename it to always_hash_content=True, to mirror the same keyword argument in Sender() and Receiver.respond().

  2. Rename it to require_content_hash=True, which is perhaps the more accurate terminology, as it allows requests to omit the hash attribute in the Hawk header, but still validates the content hash if included.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions