Skip to content

Commit 99fa3c9

Browse files
authored
add run_unasync_check to CI (#90)
* add run_unasync_check to CI * update minimum python to 3.10
1 parent 8591b6b commit 99fa3c9

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

.github/workflows/_integration_test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
python-version:
31-
- "3.9"
3231
- "3.10"
3332
- "3.11"
3433
- "3.12"

.github/workflows/_lint.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
# Starting new jobs is also relatively slow,
3030
# so linting on fewer versions makes CI faster.
3131
python-version:
32-
- "3.9"
32+
- "3.10"
3333
- "3.13"
3434
steps:
3535
- uses: actions/checkout@v4
@@ -40,7 +40,7 @@ jobs:
4040
python-version: ${{ matrix.python-version }}
4141
poetry-version: ${{ env.POETRY_VERSION }}
4242
working-directory: ${{ inputs.working-directory }}
43-
cache-key: lint-with-extras
43+
cache-key: lint-with-extras-codegen
4444

4545
- name: Check Poetry File
4646
shell: bash
@@ -55,12 +55,14 @@ jobs:
5555
# This helps catch errors that require dependencies to be spotted, for example:
5656
# https://github.com/langchain-ai/langchain/pull/10249/files#diff-935185cd488d015f026dcd9e19616ff62863e8cde8c0bee70318d3ccbca98341
5757
#
58+
# Also installs codegen dependencies (unasync) needed for run_unasync_check.
59+
#
5860
# If you change this configuration, make sure to change the `cache-key`
5961
# in the `poetry_setup` action above to stop using the old cache.
6062
# It doesn't matter how you change it, any change will cause a cache-bust.
6163
working-directory: ${{ inputs.working-directory }}
6264
run: |
63-
poetry install --with lint,typing
65+
poetry install --with lint,typing,codegen
6466
6567
- name: Get .mypy_cache to speed up mypy
6668
uses: actions/cache@v4
@@ -95,3 +97,8 @@ jobs:
9597
working-directory: ${{ inputs.working-directory }}
9698
run: |
9799
make lint_tests
100+
101+
- name: Check that sync files match unasync-generated files
102+
working-directory: ${{ inputs.working-directory }}
103+
run: |
104+
make run_unasync_check

.github/workflows/_test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
fail-fast: false
2222
matrix:
2323
python-version:
24-
- "3.9"
2524
- "3.10"
2625
- "3.11"
2726
- "3.12"

libs/elasticsearch/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ license = "MIT"
1111
"Source Code" = "https://github.com/langchain-ai/langchain-elastic/tree/main/libs/elasticsearch"
1212

1313
[tool.poetry.dependencies]
14-
python = ">=3.9,<4.0"
14+
python = ">=3.10,<4.0"
1515
langchain-core = "^0.3.0"
1616
elasticsearch = {version = ">=8.16.0,<9.0.0", extras = ["vectorstore_mmr"]}
1717

0 commit comments

Comments
 (0)