Summary
axios 401 interceptor unconditionally clears the GitHub provider token cookie, racing with refresh.
Source
P2 follow-up from /ship adversarial review of PR #176 (silent GitHub token refresh).
Details
src/lib/axios-github.ts:101-110 unconditionally calls deleteGitHubTokenCookie() on any 401. A stale request resolving after refresh completes can nuke the fresh cookie.
Fix
Gate deletion on the in-flight token matching the current cookie value.
Acceptance
Summary
axios 401 interceptor unconditionally clears the GitHub provider token cookie, racing with refresh.
Source
P2 follow-up from
/shipadversarial review of PR #176 (silent GitHub token refresh).Details
src/lib/axios-github.ts:101-110unconditionally callsdeleteGitHubTokenCookie()on any 401. A stale request resolving after refresh completes can nuke the fresh cookie.Fix
Gate deletion on the in-flight token matching the current cookie value.
Acceptance