Jank thread

[leios]

This is a list of all the "jank" I come across with this codebase as it is written. If you are a user of quibble, please feel free to discuss weird issues you have here!

What jank needs to be fixed:

• I should be using strncat instead of strcat
• I should be using snprintf instead of printf
• I should limit MAX_SOURCE_SIZE and maybe do something where I allocate new pages if I run out of space.
• Priority colors will allocate a new array when outputting to file
  • Simple solution: carry around an output array in addition to host_data that is only used for priority colors (and otherwise NULL).
  • deprioritize_array(quibble_pixels pqs), which will do an in-place deprioritize without a malloc. We can remove the other function.

What jank is mentioned in the docs?

• qb_combine_program...(...) will not combine all auxiliary functions (everything_else) because it is intended to be used only during the build step. This means that if users wish to use this function, they will need to combine the programs, then combine everything_elses, and then build separately!
• Quibble -> qbtest; building lib #25 (comment)
• Quibble colors need to be unrolled for gpu execution because the datatype is not a multiple of 16. I think. I am not really sure the exact reason and need to think about it.

No longer tracking:

• qb_configure_verse and qb_configure_echo issues: Jank thread #8 (comment)

[leios]

So the qb_configure_verse and qb_configure_echo functions introduced in #4 both use a C-style variadic function so users can change multiple keyword arguments at the same time. There are a few consequences of this because the compiler will automatically make assumptions about certain types. For example:

1. All floats are converted to doubles. This is not inherently a huge issue, but the numbers are then converted to a string via the qb_float_to_string (or qb_double_to_string) function for use in the final quibble verse. Because of this, if users implement a longish float value like 8.0000001, the final 1 might get cut off in the conversion to a string.
2. Ints do not get automatically converted to floats. For example: qb_configure_verse(&qv, 1, "x", "float", 5); will not set x = 5.0, but instead x = 0.0 because double arg = va_arg(args, double); in the variadic function cannot parse an integer value into a double correctly.

Note that there may be a solution to this with proper type unions: https://stackoverflow.com/a/27476025, but it's still not quite clear how I would do this in practice and I've got bigger fish to fry right now.

NOTE: These functions have been removed and now variadic functions are only used for argument configuration.

[leios]

Quibble pixels are not aligned properly on GPU data, so you sometimes (probably always) need to unroll the struct like so:

qp.red = ...
qp.green = ...
qp.blue = ...
qp.alpha = ...

93ec008#diff-f2f8a3e7b070354f3529c8944f4f7df8fdeb08e906bb108396a5a3edecff12fdL226