Stabilize CI browser tail failures

Author: KSemenenko

tests/PrompterOne.Web.UITests/Editor/EditorDocumentSplitFlowTests.cs

@@ -37,7 +37,10 @@ public Task EditorScreen_SplitBySegmentHeadingCreatesLibraryScriptsWithoutReplac
 
             await page.GetByTestId(UiTestIds.Editor.SplitSegment).ClickAsync();
 
-            await Expect(page.GetByTestId(UiTestIds.Editor.SplitStatus)).ToBeVisibleAsync();
+            await Expect(page.GetByTestId(UiTestIds.Editor.SplitStatus)).ToBeVisibleAsync(new()
+            {
+                Timeout = BrowserTestConstants.EditorFlow.SplitFeedbackVisibleTimeoutMs
+            });
             await Expect(page.GetByTestId(UiTestIds.Editor.SplitResultTitle)).ToHaveTextAsync(SplitFeedbackTitle);
             await Expect(page.GetByTestId(UiTestIds.Editor.SplitResultSummary)).ToHaveTextAsync(SplitFeedbackSummary);
             await Expect(page.GetByTestId(UiTestIds.Editor.SplitResultBadge)).ToHaveTextAsync(SplitFeedbackBadge);

tests/PrompterOne.Web.UITests/Editor/EditorFloatingToolbarLayoutTests.cs

@@ -99,7 +99,7 @@ public async Task EditorScreen_FloatingToolbarStaysPinnedAfterFloatingFormatActi
             await GotoEditorAndWaitForSourceAsync(page);
             await EditorMonacoDriver.SetCaretAtTextStartAsync(page, BrowserTestConstants.Editor.ToolbarPinnedSelectionTarget);
             await EditorMonacoDriver.FocusAsync(page);
-            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+            await EditorMonacoDriver.ExpandSelectionWithKeyAsync(
                 page,
                 BrowserTestConstants.Keyboard.ShiftArrowRight,
                 BrowserTestConstants.Editor.ToolbarPinnedSelectionCharacterCount);

tests/PrompterOne.Web.UITests/Editor/EditorSelectionRenderRegressionTests.cs

@@ -48,7 +48,7 @@ public async Task EditorScreen_BackwardSelection_KeepsGrowingAcrossRepeatedArrow
             await EditorMonacoDriver.SetTextAsync(page, BrowserTestConstants.Editor.TypedScript);
             await EditorMonacoDriver.SetCaretAtTextEndAsync(page, BrowserTestConstants.Editor.ReverseSelectionTarget);
             await EditorMonacoDriver.FocusAsync(page);
-            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+            await EditorMonacoDriver.ExpandSelectionWithKeyAsync(
                 page,
                 BrowserTestConstants.Keyboard.ShiftArrowLeft,
                 BrowserTestConstants.Editor.ReverseSelectionCharacterCount);
@@ -78,7 +78,7 @@ public async Task EditorScreen_BackwardSelection_CanExtendAcrossLineBreaks()
             await EditorMonacoDriver.SetTextAsync(page, BrowserTestConstants.Editor.TypedMultilineScript);
             await EditorMonacoDriver.SetCaretAtTextEndAsync(page, BrowserTestConstants.Editor.ReverseMultilineSelectionTarget);
             await EditorMonacoDriver.FocusAsync(page);
-            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+            await EditorMonacoDriver.ExpandSelectionWithKeyAsync(
                 page,
                 BrowserTestConstants.Keyboard.ShiftArrowLeft,
                 BrowserTestConstants.Editor.ReverseMultilineSelectionCharacterCount);

tests/PrompterOne.Web.UITests/Support/BrowserTestConstants.ScreenFlows.cs

@@ -20,6 +20,7 @@ public static class EditorFlow
         public const string LineNumbersStep = "01-gutter-visible";
         public const string SplitFeedbackScenario = "editor-split-feedback";
         public const string SplitFeedbackStep = "01-split-result-card";
+        public const int SplitFeedbackVisibleTimeoutMs = 30_000;
         public const string LocalHistoryScenario = "editor-local-history";
         public const string LocalHistorySavedStep = "01-history-populated";
         public const string LocalHistoryRestoredStep = "02-history-restored";

tests/PrompterOne.Web.UITests/Support/EditorLargeDraftPerformanceTestData.cs

@@ -6,15 +6,16 @@ namespace PrompterOne.Web.UITests;
 internal static class EditorLargeDraftPerformanceTestData
 {
     public const int BlockCountPerSegment = 4;
+    public const int CiMaxHugeFollowupLongTaskMs = 550;
     public const int CiMaxHugeTypingLatencyMs = 425;
-    public const int CiMaxPasteLongTaskMs = 360;
+    public const int CiMaxPasteLongTaskMs = 375;
     public const string FollowupTypingText = " x";
     public const int HugeDraftMinimumLength = 250_000;
     public const int HugeDraftReadyTimeoutMs = 30_000;
     public const int LargeDraftMinimumLength = 32_000;
+    public const int LocalMaxHugeFollowupLongTaskMs = 500;
     public const int LocalMaxHugeTypingLatencyMs = 250;
     public const int LocalMaxPasteLongTaskMs = 325;
-    public const int MaxHugeFollowupLongTaskMs = 500;
     public const int MaxTypingLatencyMs = 100;
     public const int NavigationTargetSegmentIndex = 14;
     public const int ObservationDelayMs = 2_200;
@@ -26,6 +27,11 @@ internal static class EditorLargeDraftPerformanceTestData
     private const string FrontMatterOpeningDelimiter = "---\n";
     private const string FrontMatterClosingDelimiter = "\n---\n\n";
 
+    public static int MaxHugeFollowupLongTaskMs =>
+        PrompterOne.Testing.TestEnvironment.IsCiEnvironment
+            ? CiMaxHugeFollowupLongTaskMs
+            : LocalMaxHugeFollowupLongTaskMs;
+
     public static int MaxHugeTypingLatencyMs =>
         PrompterOne.Testing.TestEnvironment.IsCiEnvironment
             ? CiMaxHugeTypingLatencyMs

tests/PrompterOne.Web.UITests/Support/EditorMonacoDriver.cs

@@ -15,6 +15,9 @@ internal sealed record DroppedFileDescriptor(string FileName, string Text);
         PropertyNameCaseInsensitive = true
     };
 
+    private static int GetSelectionLength(EditorMonacoState state) =>
+        Math.Abs(state.Selection.End - state.Selection.Start);
+
     internal static ILocator SourceInput(IPage page) =>
         page.GetByTestId(UiTestIds.Editor.SourceInput);
 
@@ -94,11 +97,35 @@ internal static async Task FocusAsync(IPage page)
         _ = await InvokeHarnessAsync<EditorMonacoState>(page, "focus");
     }
 
-    internal static async Task PressKeyRepeatedlyAsync(IPage page, string key, int repeatCount)
+    internal static async Task ExpandSelectionWithKeyAsync(IPage page, string key, int repeatCount)
     {
+        var currentSelectionLength = GetSelectionLength(await GetStateAsync(page));
+
         for (var index = 0; index < repeatCount; index++)
         {
             await page.Keyboard.PressAsync(key);
+            currentSelectionLength += 1;
+
+            await page.WaitForFunctionAsync(
+                """
+                (args) => {
+                    const harness = window[args.harnessGlobalName];
+                    const state = harness?.getState(args.testId);
+                    const selection = state?.selection;
+                    if (!selection) {
+                        return false;
+                    }
+
+                    return Math.abs(selection.end - selection.start) >= args.minimumSelectionLength;
+                }
+                """,
+                new
+                {
+                    harnessGlobalName = EditorMonacoRuntimeContract.BrowserHarnessGlobalName,
+                    minimumSelectionLength = currentSelectionLength,
+                    testId = UiTestIds.Editor.SourceStage
+                },
+                new() { Timeout = BrowserTestConstants.Timing.FastVisibleTimeoutMs });
         }
     }