feat: Flush notebook to disk on restart#10004
Open
mchav wants to merge 1 commit into
Open
Conversation
Mis-timed restarts don't save the notebook to disk properly and result in data loss.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant User as User
participant UI as useRestartKernel
participant Save as useSaveNotebook
participant Persist as Notebook Persistence
participant WS as WebSocket
participant Kernel as Kernel
User->>UI: Click restart kernel
UI->>UI: Open confirm dialog
UI->>User: Show updated description
User->>UI: Confirm restart
UI->>Save: saveIfNotebookIsPersistent()
Note right of Save: Checks if notebook is a persistent file
alt Notebook is persistent file
Save->>Persist: Save notebook to disk
Persist-->>Save: Save result
else Save fails (caught)
Save-->>UI: Error thrown
UI->>UI: Logger.warn() – non‑fatal
end
UI->>WS: setConnection(CLOSING)
UI->>Kernel: sendRestart()
Kernel-->>UI: Acknowledged
UI->>UI: reloadSafe() → page reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Mis-timed restarts don't save the notebook to disk properly and result in data loss. The PR flushes the notebook to disk before initiating a restart.
📋 Pre-Review Checklist
✅ Merge Checklist