You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tracking issue for cleanup of the rclone cloud-sync subsystem (projects/ROCKNIX/packages/network/rclone/), based on a review of the code, the cloud-sync docs, and recent rclone commit history.
Bugs
🔴 Rclone_fixes_for_system_backups #1 — --delete-excluded never stripped on restore (local data-loss risk).cloud_backup builds RESTORE_RCLONEOPTS by stripping --delete-excluded (cloud_backup:281), but in cloud_restore the same var is computed (cloud_restore:347) and then never used — game-saves restore passes the full RCLONE_OPTS_ARRAY (cloud_restore:430,440), which still contains --delete-excluded. With RESTOREMETHOD="sync", restore can delete local files matched by excludes/filters (BIOS, *.zip, etc.). Wire cloud_restore to use the stripped opts (or drop --delete-excluded on the restore path).
🟠 Update kernel configs/device documentation #2 — cloud_sync_helper truncates multi-line RCLONEOPTS on from-scratch create/merge.update_cloud_sync_config reads defaults with IFS='=' read -r key value (cloud_sync_helper:114); DEFAULT_RCLONEOPTS spans 4 lines with \ continuations (cloud_sync.conf.defaults:32-35), so only the first line is captured → writes a truncated RCLONEOPTS="--progress \ with dangling backslash/unterminated quote. Masked today because cloud_sync.conf always ships, but the from-scratch branch (cloud_sync_helper:138-143) is latently broken.
🟠 Update kernel configs/device documentation #3 — RSYNCRMDIR documented + shipped but unimplemented. Present in cloud_sync.conf/.defaults (line 64) and the website ("remove empty remote directories"), but no script references it. Either implement it or remove it from config + docs.
🟡 Sync fork with latest upstream ROCKNIX/distribution (next) #4 — Log-level comment/behavior mismatch. Comment says "Set log level to DEBUG when INFO is selected" but code sets --log-level INFO (cloud_backup:374-381, cloud_restore:428-435). Fix comment or behavior.
🟡 rclone cloud-sync cleanup punch list #5 — report_rclone_error mislabels exit code 9. rclone 9 = success, but no files transferred; script logs it as "Operation failed - no retry" (cloud_backup:301, cloud_restore equivalent). Re-map to a success/warn.
🟡 Finish RK3566 input ROCKNIX/distribution#6 — Minor inconsistencies.--stats-one-line and the --progress-terminal-width capability check only exist in the system-backup restore path (cloud_restore:514-519), not game-saves. Some read_controller_input quoted regexes (e.g. "code 0.*value…", cloud_backup:101) are matched literally so those branches never fire.
Docs (rocknix.org/configure/cloud-sync)
Document LOG_LEVEL, rclonectl mount/unmount, and cloud_sync_cleanup_duplicates.sh.
Note the single-remote assumption (rclone listremotes | head -1, cloud_backup:503) — only the first configured remote is used.
Tracking issue for cleanup of the rclone cloud-sync subsystem (
projects/ROCKNIX/packages/network/rclone/), based on a review of the code, the cloud-sync docs, and recent rclone commit history.Bugs
--delete-excludednever stripped on restore (local data-loss risk).cloud_backupbuildsRESTORE_RCLONEOPTSby stripping--delete-excluded(cloud_backup:281), but incloud_restorethe same var is computed (cloud_restore:347) and then never used — game-saves restore passes the fullRCLONE_OPTS_ARRAY(cloud_restore:430,440), which still contains--delete-excluded. WithRESTOREMETHOD="sync", restore can delete local files matched by excludes/filters (BIOS,*.zip, etc.). Wirecloud_restoreto use the stripped opts (or drop--delete-excludedon the restore path).cloud_sync_helpertruncates multi-lineRCLONEOPTSon from-scratch create/merge.update_cloud_sync_configreads defaults withIFS='=' read -r key value(cloud_sync_helper:114);DEFAULT_RCLONEOPTSspans 4 lines with\continuations (cloud_sync.conf.defaults:32-35), so only the first line is captured → writes a truncatedRCLONEOPTS="--progress \with dangling backslash/unterminated quote. Masked today becausecloud_sync.confalways ships, but the from-scratch branch (cloud_sync_helper:138-143) is latently broken.RSYNCRMDIRdocumented + shipped but unimplemented. Present incloud_sync.conf/.defaults(line 64) and the website ("remove empty remote directories"), but no script references it. Either implement it or remove it from config + docs.--log-level INFO(cloud_backup:374-381,cloud_restore:428-435). Fix comment or behavior.report_rclone_errormislabels exit code 9. rclone9= success, but no files transferred; script logs it as "Operation failed - no retry" (cloud_backup:301,cloud_restoreequivalent). Re-map to a success/warn.--stats-one-lineand the--progress-terminal-widthcapability check only exist in the system-backup restore path (cloud_restore:514-519), not game-saves. Someread_controller_inputquoted regexes (e.g."code 0.*value…",cloud_backup:101) are matched literally so those branches never fire.Docs (rocknix.org/configure/cloud-sync)
LOG_LEVEL,rclonectlmount/unmount, andcloud_sync_cleanup_duplicates.sh.rclone listremotes | head -1,cloud_backup:503) — only the first configured remote is used.RSYNCRMDIRdoc vs. code (ties to Update kernel configs/device documentation #3).Notes / context
cloud_sync_helperso both scripts stay consistent (root cause of Rclone_fixes_for_system_backups #1/Update kernel configs/device documentation #2 and the past--verbose/-vvs--log-levelconflict campaign — Update rclone package version and refine backup/restore scripts ROCKNIX/distribution#1739/Fixed rclone parameter conflicts and added file-level logging ROCKNIX/distribution#1726/rclonepost-updatefix ROCKNIX/distribution#1747/Fix rclone --verbose conflict ROCKNIX/distribution#1916).rclone-bisync-beta(plans/bisync/rclone-bisync-planning.md), not yet innext.