-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
addToCartWorkflow return type #14240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
addToCartWorkflow return type #14240
Conversation
🦋 Changeset detectedLatest commit: 167d44d The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gladius882 is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| ) | ||
|
|
||
| return new WorkflowResponse(void 0, { | ||
| return new WorkflowResponse(createdLineItems, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Return value excludes updated line items from result
The workflow returns only createdLineItems, but when adding an item with a variant that already exists in the cart, the workflow updates the existing line item's quantity instead of creating a new one. In this case, createdLineItems is empty while updatedLineItems contains the affected item. The return value would be an empty array even though the add-to-cart succeeded. The existing allItems variable (which combines both created and updated items) would be more appropriate to return.
Summary
What — What changes are introduced in this PR?
addToCartWorkflow now return created line items instead of void
Why — Why are these changes relevant or necessary?
This change allow to easier operate on the returned line items instead of retrieving it manually.
How — How have these changes been implemented?
Edit of addToCartWorkflow return statement
Testing — How have these changes been tested, or how can the reviewer test the feature?
Please provide answer here
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsNote
addToCartWorkflow now returns the created line items instead of void.
add-to-cartworkflow (packages/core/core-flows/src/cart/workflows/add-to-cart.ts):createdLineItemsvianew WorkflowResponse(createdLineItems, ...)(previously returnedvoid).@medusajs/core-flows.Written by Cursor Bugbot for commit 167d44d. This will update automatically on new commits. Configure here.