autonomy: personal.db -> agent.db; cover the last two matrix rows

The store file was still named personal.db. It holds state for any agent
running unattended, not a species of agent — rename it, and note in place that
it is opened lazily so an ordinary conversational agent never grows one.

That claim is now a test rather than a comment: TestOrdinaryAgentGetsNoAutonomyStore
creates a plain agent, exercises the admin surface against it, and asserts no
agent.db appears — the governance machinery costs nothing until asked for.

Also covers the remaining orthogonality row: an agent WITH an objective but
WITHOUT autonomy still wakes on demand, reaching the policy gate rather than
being refused for lacking autonomy. Autonomy governs unprompted action, not
whether a human may ask.

All four combinations of (objective, autonomous) now have a test.

Author: timothyerwin

cmd/admin_autonomy_test.go

@@ -244,3 +244,37 @@ func TestDoctorAndInbox(t *testing.T) {
 		t.Fatalf("inbox=%q", out)
 	}
 }
+
+// The fourth combination: an ordinary agent — no objective, not autonomous —
+// stays exactly as it was. In particular it grows no autonomy store, so the
+// governance machinery costs nothing until someone asks for it.
+func TestOrdinaryAgentGetsNoAutonomyStore(t *testing.T) {
+	home := setupAgentHome(t)
+	admin(t, tools.GwAgent, map[string]any{"action": "add", "name": "plain"})
+	admin(t, tools.GwOverview, nil)
+
+	cfg, _ := gwconfig.Load()
+	a := cfg.Agents["plain"]
+	if a.Autonomous || a.Objective != "" || a.Paused {
+		t.Fatalf("ordinary agent picked up autonomy settings: %+v", a)
+	}
+	if _, err := os.Stat(filepath.Join(home, ".memcode", "agents", "plain", "agent.db")); !os.IsNotExist(err) {
+		t.Fatalf("ordinary agent grew an autonomy store (err=%v)", err)
+	}
+}
+
+// An agent with an objective but WITHOUT autonomy still works on demand — the
+// grant governs unprompted action, not whether a human may ask.
+func TestObjectiveWithoutAutonomyStillWakesOnDemand(t *testing.T) {
+	setupAgentHome(t)
+	admin(t, tools.GwAgent, map[string]any{"action": "add", "name": "ondemand", "objective": "Tidy notes"})
+	cfg, _ := gwconfig.Load()
+	if cfg.Agents["ondemand"].Autonomous {
+		t.Fatal("became autonomous")
+	}
+	// Reaches the policy gate rather than being refused for lacking autonomy.
+	out := admin(t, tools.GwWake, map[string]any{"agent": "ondemand"})
+	if !strings.Contains(out, "blocked") || !strings.Contains(out, "policy") {
+		t.Fatalf("expected the policy gate, not an autonomy refusal: %q", out)
+	}
+}

internal/agent/autonomy/store.go

@@ -44,7 +44,10 @@ func Open(ctx context.Context, home string) (*Store, error) {
 	if err := InitializeHome(home); err != nil {
 		return nil, fmt.Errorf("initialize agent home: %w", err)
 	}
-	path := filepath.Join(home, "personal.db")
+	// agent.db, not personal.db: this is state for any agent running
+	// unattended, not a separate species of agent. Opened lazily, so an
+	// ordinary conversational agent never grows one.
+	path := filepath.Join(home, "agent.db")
 	db, err := sql.Open("sqlite", path)
 	if err != nil {
 		return nil, fmt.Errorf("opening %s: %w", path, err)

internal/agent/autonomy/store_test.go

@@ -19,7 +19,7 @@ func TestOpenInitializesHomeAndSchema(t *testing.T) {
 	}
 	defer s.Close()
 
-	for _, path := range []string{"personal.db", "policies", "workspace/generated", "workspace/scratch", "runs", "workers", ".memcode/jobs", ".memcode/sessions"} {
+	for _, path := range []string{"agent.db", "policies", "workspace/generated", "workspace/scratch", "runs", "workers", ".memcode/jobs", ".memcode/sessions"} {
 		if _, err := os.Stat(filepath.Join(home, path)); err != nil {
 			t.Errorf("missing %s: %v", path, err)
 		}