[Event Request] Report 31012 "Create Sales Adv. Letter CZZ".OnPostReport

[fridrichovsky]

Why do you need this change?

Problem statement:
Our module works with web orders and this require skip confirmations during Sales Advance Header create. We ask for option how to skip confirmations during this process for automatic tasks.

Alternatives evaluated:
There is no event that allow skip confirmation dialog and skip open page.

Proposed publisher location:
Object: Report 31012 "Create Sales Adv. Letter CZZ".OnPostReport near to confirmation codeunit.

Proposed code snippet (before -> after):

trigger OnPostReport()
var
    ConfirmManagement: Codeunit "Confirm Management";
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
    IsHandled: Boolean;
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END
    OpenAdvanceLetterQst: Label 'Do you want to open created Advance Letter?';
begin
    case SourceType of
        SourceType::SalesOrder:
            begin
                CreateAdvanceLetterHeader(SourceSalesHeader);
                CreateAdvanceLetterLine(TempSalesLine);
                CreateAdvanceLetterApplication();
            end;
        SourceType::Job:
            begin
                CreateAdvanceLetterHeader(SourceJob);
                CreateAdvanceLetterLine(TempJobPlanningLine);
            end;
        SourceType::JobTask:
            begin
                CreateAdvanceLetterHeader(SourceJobTask);
                CreateAdvanceLetterLine(TempJobPlanningLine);
            end;
    end;
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
    OnPostReportOnBeforeConfitmOpenAdvanceLetter(SalesAdvLetterHeaderCZZ, IsHandled);
    if not IsHandled then
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END
        if ConfirmManagement.GetResponseOrDefault(OpenAdvanceLetterQst, false) then
            if GuiAllowed() then
                Page.Run(Page::"Sales Advance Letter CZZ", SalesAdvLetterHeaderCZZ);
end;

//------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
[IntegrationEvent(false, false)]
local procedure OnPostReportOnBeforeConfitmOpenAdvanceLetter(SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; var IsHandled: boolean)
begin
end;
//------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END

Performance & data considerations:
There is no addition cycles and actions so there don't change performance. Data are not affected because everything is created only show card will be skipped.

Multi‑extension interaction:
There is no conflict with another extension because it doesn't skip function or procedures with events.

Justification for using IsHandled over alternatives:
We tried find another solution, but there is no another option then isHandled.

Describe the request

trigger OnPostReport()
var
    ConfirmManagement: Codeunit "Confirm Management";
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
    IsHandled: Boolean;
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END
    OpenAdvanceLetterQst: Label 'Do you want to open created Advance Letter?';
begin
    case SourceType of
        SourceType::SalesOrder:
            begin
                CreateAdvanceLetterHeader(SourceSalesHeader);
                CreateAdvanceLetterLine(TempSalesLine);
                CreateAdvanceLetterApplication();
            end;
        SourceType::Job:
            begin
                CreateAdvanceLetterHeader(SourceJob);
                CreateAdvanceLetterLine(TempJobPlanningLine);
            end;
        SourceType::JobTask:
            begin
                CreateAdvanceLetterHeader(SourceJobTask);
                CreateAdvanceLetterLine(TempJobPlanningLine);
            end;
    end;
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
    OnPostReportOnBeforeConfitmOpenAdvanceLetter(SalesAdvLetterHeaderCZZ, IsHandled);
    if not IsHandled then
    //------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END
        if ConfirmManagement.GetResponseOrDefault(OpenAdvanceLetterQst, false) then
            if GuiAllowed() then
                Page.Run(Page::"Sales Advance Letter CZZ", SalesAdvLetterHeaderCZZ);
end;

//------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:BEGIN
[IntegrationEvent(false, false)]
local procedure OnPostReportOnBeforeConfitmOpenAdvanceLetter(SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; var IsHandled: boolean)
begin
end;
//------------------------------------------OnPostReportOnBeforeConfitmOpenAdvanceLetter:END

[github-actions]

Hi F!do (@fridrichovsky),

Thank you for your extensibility request.

The code you'd like to change is part of the BCApps repository. To have this change made, it needs to go through a contribution.
Please refer to the contribution guide for instructions on how to proceed: https://github.com/microsoft/BCApps/blob/main/CONTRIBUTING.md

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[fridrichovsky]

Hello Jesper Schulz-Wedde (@JesperSchulz),
I would ask you how can I create new event request in new repository there are old templates for issues. I can do it as PR for you it is not problem, but documentation say that I have to have approved issue. Thank you for your answer.