`custom_domain` and `tre_url` settings are confusing

[tamirkamara]

Those 2 settings are almost the same thing in the intent but in fact don't do the same thing.
I think we should fold them under a single setting.

[marrobi]

Could do this:

• Keep tre_url as the canonical setting (full URL).
• Where only the DNS name is needed, extract it programmatically from tre_url (e.g., using Python's urllib.parse or similar library in other languages).
• Remove custom_domain from user configuration to avoid confusion and derive it automatically from tre_url everywhere it’s needed.
• Update documentation to clarify that tre_url is required, and custom_domain is derived.

@tamirkamara thoughts?

[james-annages]

@marrobi My consern with building the URL progromatly is that the cert managment and reidrect urls become more chalanaging to manage if the users want to use a custom url (like i do).

[marrobi]

Is the same DNS name not used across all of these? We should look to see if tre_url or custom_domain is set, if it isn't use the app gateway FQDN.

[marrobi]

I think tre_url makes more sense as it includes http/https which is needed for local dev.

[james-annages]

@marrobi happy for it to be chnaged, just did not want to lose the functonantly of the custom domain

[marrobi]

@james-annages what do you think of #4631? Thanks.

[james-annages]

@james-annages what do you think of #4631? Thanks.

@marrobi sorry for the delay, that looks better. keeps things simple with the config and lets people use custom URL if they want.

[marrobi]

@james-annages can you drop me an email/teams message, marrobi at microsoft.com. Thanks.