Rename BarChartNice to ScaleNice for generality

Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com>

Author: Copilot

packages/sanddance-explorer/src/dialogs/settings.tsx

@@ -65,7 +65,7 @@ function filterSignals(signal: NewSignal) {
         case SandDance.constants.SignalNames.ColorReverse:
         case SandDance.constants.SignalNames.PointScale:
         case SandDance.constants.SignalNames.TreeMapMethod:
-        case SandDance.constants.SignalNames.BarChartNice:
+        case SandDance.constants.SignalNames.ScaleNice:
         case SandDance.constants.SignalNames.ZGrounded:
             return false;
         default:

packages/sanddance-specs/src/charts/barchartH.ts

@@ -62,8 +62,8 @@ export default function (specContext: SpecContext): SpecBuilderProps {
         });
     } else {
         const aggProps: AggregateContainerProps = {
-            niceScale: { signal: SignalNames.BarChartNice },
-            niceScaleDisplay: specViewOptions.language.barChartNice,
+            niceScale: { signal: SignalNames.ScaleNice },
+            niceScaleDisplay: specViewOptions.language.scaleNice,
             dock: 'left',
             globalAggregateMaxExtentSignal: 'aggMaxExtent',
             globalAggregateMaxExtentScaledSignal: 'aggMaxExtentScaled',
@@ -154,7 +154,7 @@ export default function (specContext: SpecContext): SpecBuilderProps {
         specCapabilities: {
             countsAndSums: true,
             percentage: true,
-            signals: totalStyle !== 'sum-strip-percent' ? [SignalNames.BarChartNice] : undefined,
+            signals: totalStyle !== 'sum-strip-percent' ? [SignalNames.ScaleNice] : undefined,
             roles: [
                 {
                     role: 'y',

packages/sanddance-specs/src/charts/barchartV.ts

@@ -62,8 +62,8 @@ export default function (specContext: SpecContext): SpecBuilderProps {
         });
     } else {
         const aggProps: AggregateContainerProps = {
-            niceScale: { signal: SignalNames.BarChartNice },
-            niceScaleDisplay: specViewOptions.language.barChartNice,
+            niceScale: { signal: SignalNames.ScaleNice },
+            niceScaleDisplay: specViewOptions.language.scaleNice,
             dock: 'bottom',
             globalAggregateMaxExtentSignal: 'aggMaxExtent',
             globalAggregateMaxExtentScaledSignal: 'aggMaxExtentScaled',
@@ -153,7 +153,7 @@ export default function (specContext: SpecContext): SpecBuilderProps {
         specCapabilities: {
             countsAndSums: true,
             percentage: true,
-            signals: totalStyle !== 'sum-strip-percent' ? [SignalNames.BarChartNice] : undefined,
+            signals: totalStyle !== 'sum-strip-percent' ? [SignalNames.ScaleNice] : undefined,
             roles: [
                 {
                     role: 'x',

packages/sanddance-specs/src/constants.ts

@@ -68,7 +68,7 @@ export const SignalNames = {
     TextSize: 'Text_SizeSignal',
     TextTitleSize: 'Text_TitleSizeSignal',
     TreeMapMethod: 'Chart_TreeMapMethodSignal',
-    BarChartNice: 'Chart_BarChartNiceSignal',
+    ScaleNice: 'Chart_ScaleNiceSignal',
     XBins: 'RoleX_BinsSignal',
     YBins: 'RoleY_BinsSignal',
     ZHeight: 'RoleZ_HeightSignal',

packages/sanddance-specs/src/layouts/aggregateContainer.ts

@@ -77,7 +77,7 @@ export class AggregateContainer extends Layout {
         if (niceScaleDisplay) {
             addSignals(globalScope.scope,
                 {
-                    name: SignalNames.BarChartNice,
+                    name: SignalNames.ScaleNice,
                     value: true,
                     bind: {
                         name: niceScaleDisplay,

packages/sanddance-specs/src/types.ts

@@ -224,9 +224,9 @@ export interface SpecLanguage {
     treeMapMethod: string;
 
     /**
-     * Label for bar chart nice scale toggle.
+     * Label for nice scale toggle.
      */
-    barChartNice: string;
+    scaleNice: string;
 
     /**
      * Label for scatterPlot point scale slider.

packages/sanddance/src/defaults.ts

@@ -52,7 +52,7 @@ export const defaultViewerOptions: ViewerOptions = {
         InnerPaddingSize: 'Inner padding size',
         OuterPaddingSize: 'Outer padding size',
         treeMapMethod: 'Treemap layout',
-        barChartNice: 'Nice scale',
+        scaleNice: 'Nice scale',
         facetColumns: 'Facet columns',
         facetRows: 'Facet rows',
         markOpacitySignal: 'Mark opacity',