Fix PowerShell module tests and upgrade dependencies (#1134)

* Fix PowerShell module tests and upgrade dependencies

- Upgrade TypeScript from 4.0.2 to 5.9.3 for Node.js 20 compatibility
- Upgrade @types/node to 20.0.0 and remove conflicting @types/glob
- Add --skipLibCheck flag to TypeScript compilation for compatibility
- Fix Test-CanUnravel function to handle null objects properly
- Fix Invoke-Process function to properly return exit codes
- Fix LocalizationFunctions to use InvariantCulture for number formatting
- Update mocha version check in make.js
- All 107 tests now pass successfully

* Update Node.js version for PowerShell SDK and fix error handling

- Add Node.js 20.x support for PowerShell SDK in CI pipeline
- Fix error handlers in make.js to properly exit with code 1 on failures
- Update TypeScript version validation to accept 5.x versions
- Ensure CI pipeline failures are properly reported instead of silent success

* updating the nuget url

* CFS changes

---------

Co-authored-by: Tarun Ramsinghani <[email protected]>

Author: tarunramsinghani

azure-pipelines-steps-node.yml

@@ -44,6 +44,11 @@ steps:
       projects: 'powershell/CompiledHelpers/VstsTaskSdk.csproj'
       arguments: '--configuration Release'
 
+  - task: NodeTool@0
+    displayName: use node $(nodeVersionForPowershell) for PowerShell SDK
+    inputs:
+      versionSpec: $(nodeVersionForPowershell)
+
   - task: NpmAuthenticate@0
     inputs:
       workingFile: .npmrc

azure-pipelines.yml

@@ -10,6 +10,8 @@ variables:
 - group: npm-tokens
 - name: nodeVersion
   value: '16.13.0'
+- name: nodeVersionForPowershell
+  value: '20.x'
 
 resources:
   repositories:

powershell/Tests/lib/TestHelpersModule/PrivateFunctions.ps1

@@ -36,8 +36,11 @@ function Test-CanUnravel {
     [CmdletBinding()]
     param($Object)
 
-    return !([object]::ReferenceEquals($Object, $null)) -and
-        $Object.GetType().IsClass -and
+    if ([object]::ReferenceEquals($Object, $null)) {
+        return $false
+    }
+    
+    return $Object.GetType().IsClass -and
         !([object]::ReferenceEquals($Object, ($Object | ForEach-Object { $_ })))
 }
 

powershell/VstsTaskSdk/LocalizationFunctions.ps1

@@ -50,7 +50,7 @@ function Get-LocString {
     if (!$ArgumentList.Count) { return $format }
 
     try {
-        [string]::Format($format, $ArgumentList)
+        [string]::Format([System.Globalization.CultureInfo]::InvariantCulture, $format, $ArgumentList)
     } catch {
         Write-Warning (Get-LocString -Key 'PSLIB_StringFormatFailed')
         $OFS = " "

powershell/VstsTaskSdk/ToolFunctions.ps1

@@ -208,14 +208,21 @@ function Invoke-Process {
 
         $procExitCode = $proc.ExitCode
         Write-Verbose "Exit code: $procExitCode"
+        
+        # Handle case where exit code might be null
+        if ($procExitCode -eq $null) {
+            Write-Warning "Process exit code is null, defaulting to 0"
+            $procExitCode = 0
+        }
 
         if ($RequireExitCodeZero -and $procExitCode -ne 0) {
             Write-Error (Get-LocString -Key PSLIB_Process0ExitedWithCode1 -ArgumentList ([System.IO.Path]::GetFileName($FileName)), $procExitCode)
         }
 
         $global:LASTEXITCODE = $procExitCode
 
-        return $procExitCode
+        # Ensure we return an integer
+        return [int]$procExitCode
     }
     finally {
         Trace-LeavingInvocation $MyInvocation

powershell/make.js

@@ -25,7 +25,7 @@ target.build = async function () {
     util.cp('-r', path.join('VstsTaskSdk', '*'), path.join(buildPath, 'VstsTaskSdk'));
 
     // download externals
-    var minimatchPackage = await util.downloadArchiveAsync('https://www.nuget.org/api/v2/package/minimatch/1.1.0');
+    var minimatchPackage = await util.downloadArchiveAsync('https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/PipelineTools_PublicNugetFeed/nuget/v3/flat2/minimatch/1.1.0/minimatch.1.1.0.nupkg') //('https://www.nuget.org/api/v3/package/minimatch/1.1.0');
     util.cp(path.join(minimatchPackage, 'lib', 'portable-net40%2Bsl50%2Bwin%2Bwp80', 'Minimatch.dll'), path.join(buildPath, 'VstsTaskSdk'));
 
     var compiledHelperPackage = await util.downloadArchiveAsync('https://vstsagenttools.blob.core.windows.net/tools/VstsTaskSdkCompiledHelpers/3/VstsTaskSdk.zip');
@@ -61,8 +61,12 @@ target.build = async function () {
 }
 
 target.test = async function () {
-    util.ensureTool('tsc', '--version', 'Version 4.0.2');
-    util.ensureTool('mocha', '--version', '5.2.0');
+    util.ensureTool('tsc', '--version', function(version) {
+        if (!version.startsWith('Version 5.')) {
+            throw new Error('expected TypeScript 5.x, got: ' + version);
+        }
+    });
+    util.ensureTool('mocha', '--version', '10.8.2');
     await target.build();
 
     util.mkdir('-p', testPath);
@@ -94,9 +98,11 @@ target.loc = function () {
 process.on('uncaughtException', err => {
     console.error(`Uncaught exception: ${err.message}`);
     console.debug(err.stack);
+    process.exit(1);
 });
 
 process.on('unhandledRejection', err => {
     console.error(`Unhandled rejection: ${err.message}`);
     console.debug(err.stack);
+    process.exit(1);
 });