list agents to be used as subagents #278624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the instructions list generation to use XML format instead of Markdown tables, and properly references tools using tool variables with the #tool: prefix. The changes improve the structure of generated instruction lists and enable proper tool reference tracking.
Key changes:
- Replaces Markdown table format with XML structure (
<instructions>,<instruction>,<skills>,<skill>tags) - Updates tool references to use the
#tool:prefix format with qualified tool names - Adds tool reference tracking via
ChatRequestToolReferenceEntrywith offset ranges for each tool mention
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts | Converts instructions list from Markdown tables to XML format, adds tool reference tracking, and injects ILanguageModelToolsService to get qualified tool names |
| src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts | Refactors getQualifiedToolName to look up tool names from the referenceable tools map instead of accepting a toolSet parameter |
src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously approved these changes
Nov 20, 2025
bpasero
previously approved these changes
Nov 22, 2025
aeschli
changed the title
dmitrivMS
previously approved these changes
Nov 22, 2025
bpasero
previously approved these changes
Nov 24, 2025
Member
|
Red CI |
joaomoreno
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.